Skip to content

Fix Weld incompatibility for webapps tests#2742

Merged
kthoms merged 1 commit into
release/1.1.xfrom
fix/2739-webapp-tests
Apr 14, 2026
Merged

Fix Weld incompatibility for webapps tests#2742
kthoms merged 1 commit into
release/1.1.xfrom
fix/2739-webapp-tests

Conversation

@kthoms

@kthoms kthoms commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

fixes #2739

Tomcat 11.0.21 upgraded to Servlet API 6.1, where
HttpServletResponse.sendRedirect(String) changed from abstract to a
default method delegating to the new sendRedirect(String, int, boolean).
Tomcat's Response class only implements the 3-arg variant, relying on
the interface default method.

weld-servlet-shaded 5.1.7.Final (Weld 5 / CDI 4.0 / Jakarta EE 10)
bundles an old HttpServletResponse where sendRedirect(String) is still
abstract. When placed in Tomcat's lib/ directory it is loaded by the
common classloader before servlet-api.jar, causing Tomcat to see the
method as abstract on Response and throw AbstractMethodError at
CoyoteAdapter.postParseRequest on every incoming request.

Upgrading to weld-servlet-shaded 6.0.4.Final (Weld 6 / CDI 4.1 /
Jakarta EE 11) bundles the updated HttpServletResponse where
sendRedirect(String) is a default method, fully compatible with
Tomcat 11.0.21.

Fixes #2739

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kthoms kthoms added this to the 1.1.2 milestone Apr 14, 2026
@kthoms kthoms added the scope:e2e-qa Changes to the E2E tests label Apr 14, 2026
Copilot AI review requested due to automatic review settings April 14, 2026 05:46
@kthoms kthoms changed the base branch from main to release/1.1.x April 14, 2026 05:46
@kthoms

kthoms commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

@kthoms kthoms merged commit f31cb0a into release/1.1.x Apr 14, 2026
16 checks passed
@kthoms kthoms deleted the fix/2739-webapp-tests branch April 14, 2026 05:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the failing Tomcat webapp integration tests (issue #2739) by updating the Tomcat/Weld test runtime setup and aligning various build/dependency versions, plus a small HTTP client regression fix and frontend build adjustments.

Changes:

  • Update QA Tomcat runtime to use a newer weld-servlet-shaded (and bump Tomcat/tooling versions) to restore webapps test startup.
  • Buffer Apache HttpClient 5 response entities in the Connect HTTP client to avoid unreadable response bodies after handler completion (with a regression test).
  • Refresh a wide set of Maven/Node dependency versions and frontend build configuration (including switching the frontend build script to production mode).

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Show a summary per file
File Description
webapps/pom.xml Bumps parent/plugin versions used by webapps build.
webapps/frontend/webpack.prod.js Re-enables CSS minimization in production build.
webapps/frontend/webpack.common.js Simplifies css-loader config; tweaks Sass output style for unicode escaping.
webapps/frontend/ui/common/styles/glyphicons-bootstap-map.scss Extends additional glyphicon mappings and fixes style syntax.
webapps/frontend/scripts/license-header-loader.js Refactors license header resolution logic (Node resolution + fallbacks).
webapps/frontend/package.json Updates frontend deps and switches build script to production mode.
webapps/assembly/pom.xml Version bump.
test-utils/testcontainers/pom.xml Version bump.
test-utils/junit5-extension/pom.xml Version bump.
test-utils/assert/qa/pom.xml Version bump.
test-utils/assert/pom.xml Version bump.
test-utils/assert/core/pom.xml Version bump.
test-utils/archunit/pom.xml Version bump.
spring-boot-starter/starter/pom.xml Version bump.
spring-boot-starter/starter-webapp/pom.xml Version bump.
spring-boot-starter/starter-webapp-core/pom.xml Version bump.
spring-boot-starter/starter-test/pom.xml Version bump.
spring-boot-starter/starter-test-junit5/pom.xml Version bump.
spring-boot-starter/starter-security/pom.xml Version bump + nimbus-jose-jwt bump.
spring-boot-starter/starter-rest/pom.xml Version bump.
spring-boot-starter/starter-qa/pom.xml Version bump.
spring-boot-starter/starter-qa/integration-test-webapp/runtime/pom.xml Version bump.
spring-boot-starter/starter-qa/integration-test-webapp/pom.xml Version bump.
spring-boot-starter/starter-qa/integration-test-webapp/invoice-example/pom.xml Version bump.
spring-boot-starter/starter-qa/integration-test-simple/pom.xml Version bump.
spring-boot-starter/starter-qa/integration-test-request-scope/pom.xml Version bump.
spring-boot-starter/starter-qa/integration-test-plugins/spin/spin-dataformat-json-jackson/pom.xml Version bump.
spring-boot-starter/starter-qa/integration-test-plugins/spin/spin-dataformat-all/pom.xml Version bump.
spring-boot-starter/starter-qa/integration-test-plugins/spin/pom.xml Version bump.
spring-boot-starter/starter-qa/integration-test-plugins/pom.xml Version bump.
spring-boot-starter/starter-qa/integration-test-liquibase/pom.xml Version bump.
spring-boot-starter/starter-client/spring/pom.xml Version bump.
spring-boot-starter/starter-client/spring-boot/pom.xml Version bump.
spring-boot-starter/pom.xml Version bump.
spin/pom.xml Version bump + json-unit version bump.
spin/dataformat-xml-dom/pom.xml Version bump.
spin/dataformat-json-jackson/pom.xml Version bump.
spin/dataformat-all/pom.xml Version bump.
spin/core/pom.xml Version bump.
quarkus-extension/pom.xml Version bump.
quarkus-extension/engine/runtime/pom.xml Version bump.
quarkus-extension/engine/qa/pom.xml Version bump.
quarkus-extension/engine/pom.xml Version bump.
quarkus-extension/engine/deployment/pom.xml Version bump.
qa/wildfly-runtime/pom.xml Version bump.
qa/tomcat-runtime/pom.xml Version bump + weld-servlet-shaded bump for Tomcat runtime.
qa/test-old-engine/pom.xml Version bump.
qa/test-db-util/pom.xml Version bump.
qa/test-db-rolling-update/test-old-engine/pom.xml Version bump.
qa/test-db-rolling-update/rolling-update-util/pom.xml Version bump.
qa/test-db-rolling-update/pom.xml Version bump.
qa/test-db-rolling-update/create-old-engine/pom.xml Version bump.
qa/test-db-rolling-update/create-new-engine/pom.xml Version bump.
qa/test-db-instance-migration/test-migration/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-79/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-78/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-77/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-76/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-75/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-74/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-73/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-724/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-723/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-722/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-721/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-720/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-72/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-719/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-718/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-717/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-716/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-715/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-714/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-713/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-712/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-711/pom.xml Version bump.
qa/test-db-instance-migration/test-fixture-710/pom.xml Version bump.
qa/test-db-instance-migration/pom.xml Version bump.
qa/pom.xml Version bump.
qa/performance-tests-engine/pom.xml Version bump.
qa/large-data-tests/pom.xml Version bump.
qa/integration-tests-webapps/shared-engine/pom.xml Version bump + failsafe plugin bump.
qa/integration-tests-webapps/pom.xml Version bump.
qa/integration-tests-webapps/integration-tests/pom.xml Version bump.
qa/integration-tests-engine/pom.xml Version bump.
qa/ensure-clean-db-plugin/pom.xml Version bump.
pom.xml Project version bump + multiple plugin/dependency version bumps.
parent/pom.xml Dependency/tooling version bumps (Tomcat, Selenium, etc.).
model-api/xml-model/pom.xml Version bump.
model-api/pom.xml Version bump.
model-api/dmn-model/pom.xml Version bump.
model-api/cmmn-model/pom.xml Version bump.
model-api/bpmn-model/pom.xml Version bump.
juel/pom.xml Version bump.
jreleaser.yml Updates previousTagName.
jakarta-ee/jobexecutor-rar/pom.xml Version bump.
jakarta-ee/jobexecutor-ra/pom.xml Version bump.
jakarta-ee/ejb-service/pom.xml Version bump.
jakarta-ee/ejb-client/pom.xml Version bump.
freemarker-template-engine/pom.xml Version bump (module + artifact version).
examples/pom.xml Version bump.
examples/invoice/pom.xml Version bump.
engine/src/test/java/org/operaton/bpm/engine/test/standalone/testing/ProcessEngineTestCaseTest.java Updates author tag text.
engine/src/test/java/org/operaton/bpm/engine/test/bpmn/sequenceflow/ConditionalSequenceFlowTest.java Updates author tag text.
engine/src/test/java/org/operaton/bpm/engine/test/bpmn/event/message/MessageBoundaryEventTest.java Updates author tag text.
engine/src/test/java/org/operaton/bpm/engine/test/api/form/FormServiceTest.java Updates author tag text.
engine/src/main/junit4/org/operaton/bpm/engine/test/ProcessEngineTestCase.java Updates author tag text.
engine/src/main/java/org/operaton/bpm/engine/impl/cmd/GetFormKeyCmd.java Updates author tag text.
engine/src/main/java/org/operaton/bpm/engine/impl/FormServiceImpl.java Updates author tag text.
engine/src/main/java/org/operaton/bpm/engine/FormService.java Adds permissions imports referenced in Javadoc; updates author tag text.
engine/pom.xml Version bump + jboss-logging patch bump.
engine-spring/pom.xml Version bump.
engine-rest/pom.xml Version bump.
engine-rest/engine-rest/pom.xml Version bump + undertow/netty version bumps in profiles.
engine-rest/engine-rest-openapi/pom.xml Version bump + openapi generator/swaggger deps bumps.
engine-rest/engine-rest-openapi-generator/pom.xml Version bump.
engine-rest/docs/pom.xml Version bump.
engine-rest/docs/package.json Version bump.
engine-rest/docs/package-lock.json Version bump + lockfileVersion bump.
engine-rest/assembly/pom.xml Version bump.
engine-plugins/spin-plugin/pom.xml Version bump.
engine-plugins/pom.xml Version bump.
engine-plugins/identity-ldap/pom.xml Version bump.
engine-plugins/connect-plugin/pom.xml Version bump.
engine-dmn/pom.xml Version bump.
engine-dmn/feel-scala/pom.xml Version bump.
engine-dmn/feel-juel/pom.xml Version bump.
engine-dmn/feel-api/pom.xml Version bump.
engine-dmn/engine/pom.xml Version bump.
engine-dmn/bom/pom.xml Version bump (module + artifact version).
engine-cdi/pom.xml Version bump + arquillian junit version bump.
distro/wildfly/webapp/pom.xml Version bump.
distro/wildfly/subsystem/pom.xml Version bump.
distro/wildfly/pom.xml Version bump.
distro/wildfly/modules/pom.xml Version bump.
distro/wildfly/distro/pom.xml Version bump.
distro/wildfly/assembly/pom.xml Version bump.
distro/webjar/pom.xml Version bump.
distro/tomcat/webapp/pom.xml Version bump.
distro/tomcat/pom.xml Version bump.
distro/tomcat/distro/pom.xml Version bump.
distro/tomcat/assembly/pom.xml Version bump.
distro/sql-script/pom.xml Version bump.
distro/run/qa/runtime/pom.xml Version bump + commons-logging + failsafe version bumps.
distro/run/qa/pom.xml Version bump.
distro/run/qa/integration-tests/pom.xml Version bump.
distro/run/qa/example-plugin/pom.xml Version bump.
distro/run/pom.xml Version bump + nimbus-jose-jwt bump in dependencyManagement.
distro/run/modules/webapps/pom.xml Version bump.
distro/run/modules/rest/pom.xml Version bump.
distro/run/modules/pom.xml Version bump.
distro/run/modules/oauth2/pom.xml Version bump.
distro/run/modules/example/pom.xml Version bump.
distro/run/distro/pom.xml Version bump.
distro/run/core/pom.xml Version bump.
distro/run/assembly/pom.xml Version bump.
distro/jboss/webapp/pom.xml Version bump.
distro/jboss/pom.xml Version bump.
database/pom.xml Version bump + JDBC driver version bumps.
connect/soap-http-client/pom.xml Version bump.
connect/pom.xml Version bump.
connect/http-client/src/test/java/org/operaton/connect/httpclient/impl/HttpRequestInvocationTest.java Adds HttpClient 5 stream-closure regression test.
connect/http-client/src/main/java/org/operaton/connect/httpclient/impl/HttpResponseImpl.java Decodes response bytes using UTF-8 explicitly.
connect/http-client/src/main/java/org/operaton/connect/httpclient/impl/HttpRequestInvocation.java Buffers response entity bytes before returning response.
connect/http-client/pom.xml Version bump.
connect/core/pom.xml Version bump.
connect/connectors-all/pom.xml Version bump.
commons/utils/src/main/java/org/operaton/commons/utils/IoUtil.java Ensures InputStream is closed via try-with-resources in byte-array conversion.
commons/utils/pom.xml Version bump.
commons/typed-values/pom.xml Version bump.
commons/testing/pom.xml Version bump.
commons/pom.xml Version bump.
commons/logging/pom.xml Version bump.
clients/java/qa/pom.xml Version bump + skips deploy for QA aggregator.
clients/java/qa/engine-variable-test/pom.xml Version bump.
clients/java/pom.xml Version bump + activates distro profile by default.
clients/java/client/pom.xml Version bump + resources plugin bump.
bom/spin/pom.xml Version bump.
bom/pom.xml Version bump.
bom/operaton-only-bom/pom.xml Version bump.
bom/operaton-bom/pom.xml Version bump.
bom/internal-dependencies/pom.xml Version bump + several dependency version bumps.
bom/connect/pom.xml Version bump.
bom/commons/pom.xml Version bump.
.github/workflows/update-sbom.yml Bumps add-and-commit action pin.
.github/workflows/unit-tests-with-databases.yaml Updates junit report action pin + upload-artifact major version.
.github/workflows/reports-and-docs.yml Updates GitHub Pages actions major versions.
.github/workflows/release.yml Updates action pins + upload-artifact major version.
.github/workflows/migration-test.yml Updates buildx action pin.
.github/workflows/integration-build.yml Updates junit report action pin + upload-artifact major version.
.github/workflows/build.yml Updates markdownlint action pin + upload-artifact major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:e2e-qa Changes to the E2E tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tomcat Webapp tests failing

2 participants