Fix tests portability for Windows#2472
Merged
Merged
Conversation
added 2 commits
February 28, 2026 15:55
- builds expected stack trace with System.lineSeparator - removes hard-coded "\n" that fails on Windows
- replace string-equality XML checks - ignore insignificant whitespace in comparisons
|
kthoms
approved these changes
Mar 1, 2026
kthoms
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I also heard from a user that there were problems on Windows with ExceptionUtilTest. Good that this is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves test portability across environments, especially Windows.
Problem
On Windows 11, tests failed due to platform-dependent formatting:
ExceptionUtilTestused hard-coded\nChanges
spin/dataformat-xml-domto use XMLUnit structural comparison:and(expected).ignoreWhitespace().areIdentical()engine/.../ExceptionUtilTestto build expected stack traces withSystem.lineSeparator()instead of hard-coded line breaks.Why This Helps
Environment (where failures were observed)
temurin-25.0.2