fix(deps): Avoid packaging of jackson-module-scala*.jar in distributions#2883
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents jackson-module-scala*.jar from being packaged into Operaton distributions to avoid FEEL engine classloading issues (e.g., NoClassDefFoundError caused by unshaded Scala references when the jar appears earlier on the classpath).
Changes:
- Exclude
com.fasterxml.jackson.module:jackson-module-scala_2.13from the transitive dependencies oforg.camunda.feel:feel-engine:scala-shadedvia the internal dependencies BOM. - Add a CI verification step in
distro/run/assemblyto assert the Run distribution’sinternal/operaton-bpm.jardoes not contain anyjackson-module-scala*.jarunderBOOT-INF/lib.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| distro/run/assembly/pom.xml | Adds a GitHub CI-only verify-phase check that inspects the assembled Run zip/jar contents for unwanted jackson-module-scala*.jar. |
| bom/internal-dependencies/pom.xml | Excludes jackson-module-scala_2.13 from the managed FEEL engine dependency to prevent it from being pulled/packaged transitively. |
The presence of jackson-module-scala*.jar can cause a NoClassDefFoundError when present in the classpath before org.camunda.feel:feel-engine:scala-shaded. The dependency is excluded. Added a verification step in module distro/run/assembly to assure that the library is not packaged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
75d9a9b to
b755188
Compare
|
kthoms
added a commit
that referenced
this pull request
May 5, 2026
…ons (#2883) The presence of jackson-module-scala*.jar can cause a NoClassDefFoundError when present in the classpath before org.camunda.feel:feel-engine:scala-shaded. The dependency is excluded. Added a verification step in module distro/run/assembly to assure that the library is not packaged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 7de9865)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presence of jackson-module-scala*.jar can cause a NoClassDefFoundError when present in the classpath before org.camunda.feel:feel-engine:scala-shaded. The dependency is excluded.
Added a verification step in module distro/run/assembly to assure that the library is not packaged.
Related to #2875