Refactor: Resolve Sonar issues#2308
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves various Sonar code quality findings across multiple modules, focusing on reducing cognitive complexity, improving Java idiom usage, and fixing serialization issues.
Changes:
- Extract methods in Tree.java to reduce cognitive complexity of the bind() method
- Add transient modifiers to non-serializable fields in ProcessDefinitionEntity
- Replace legacy Java patterns with modern idioms (computeIfAbsent, List.sort, Objects.requireNonNullElse) in GetActivityInstanceCmd
- Suppress justified cognitive complexity warning in TypeConverterImpl
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| juel/src/main/java/org/operaton/bpm/impl/juel/TypeConverterImpl.java | Adds Sonar suppression annotation for complex type coercion method |
| juel/src/main/java/org/operaton/bpm/impl/juel/Tree.java | Extracts three helper methods (resolveIdentifiers, resolveFunctions, resolveFunction) to reduce complexity of bind() method |
| engine/src/main/java/org/operaton/bpm/engine/impl/persistence/entity/ProcessDefinitionEntity.java | Marks runtime/cached fields as transient to prevent serialization issues |
| engine/src/main/java/org/operaton/bpm/engine/impl/cmd/GetActivityInstanceCmd.java | Modernizes code with Java 8+ idioms (computeIfAbsent, List.sort, Objects.requireNonNullElse) and fixes comment punctuation |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #511