PR #102607: Add support for Linux RISC-V 64#33468
Closed
copybara-service[bot] wants to merge 1 commit intomainfrom
Closed
PR #102607: Add support for Linux RISC-V 64#33468copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
8b9915f to
0c408b1
Compare
Imported from GitHub PR tensorflow/tensorflow#102607 This commit fixes #102159 which prevented TensorFlow from compiling on RISC-V 64 due to missing codepath in the build system. RFC: Currently this patch overrides timeout of rules_python for all platforms which is obviously not ideal. How do we set pip package timeout here in Tensorflow? See also: - bazelbuild/bazel#25236 - bazelbuild/bazel#25699 - bazel-contrib/rules_python#3350 - #32812 - tensorflow/runtime#135 Copybara import of the project: -- 13b7db883e6ea0aa631490fb5f806c55ceea7cb5 by gns <root@infi.wang>: [XLA:CPU] Add support for riscv64 Co-authored-by: Levi Zim <rsworktech@outlook.com> -- a00c3a3ba94664798960cbc2fb0a6746fe0c3ac1 by gns <root@infi.wang>: Add missing llvm:: namespace qualifiers for DTensor Add the `llvm::` namespace prefix to `cast` and `isa` where it was missing in the DTensor MLIR code. -- febc5abc56ab302f5f39fe20176ed00c0c95cb7e by gns <root@infi.wang>: runtime: add missing stdint header Co-authored-by: Levi Zim <rsworktech@outlook.com> -- 6bf63fec56a6d961b06d932fe69b76eae89d8cb7 by gns <root@infi.wang>: Add riscv64 support patch for rules_python bazel-contrib/rules_python#3350 -- 68c44fa9613d5577f36c51a192c932795e13ed83 by gns <root@infi.wang>: tools: py: add riscv64 to pip and manylinux compilance test -- 3f2fe1e0256476449f64658219d997727c9cc534 by gns <root@infi.wang>: Lift timeout of rules_python for BFS wheels -- 252a9b7ad2336b7abbb94e269b4a976b45d5d6e7 by gns <root@infi.wang>: Revert llvm toolchain patch for riscv64 As already upstreamed. Co-authored-by: Levi Zim <rsworktech@outlook.com> -- 51047a86131e991ffea74fccb8f55e3521237a64 by gns <root@infi.wang>: Lift timeout for BFS wheels during pip init -- 3b8276420031969423c9a1f150341a0e41fa372e by gns <root@infi.wang>: Refresh `rules_python` riscv64 patch Co-authored-by: Levi Zim <rsworktech@outlook.com> Merging this change closes #102607 FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#102607 from infiWang:riscv64 3b8276420031969423c9a1f150341a0e41fa372e PiperOrigin-RevId: 825073762
0c408b1 to
dbdab00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #102607: Add support for Linux RISC-V 64
Imported from GitHub PR tensorflow/tensorflow#102607
This commit fixes #102159 which prevented TensorFlow from compiling on RISC-V 64 due to missing codepath in the build system.
RFC: Currently this patch overrides timeout of rules_python for all platforms which is obviously not ideal. How do we set pip package timeout here in Tensorflow?
See also:
Copybara import of the project:
--
13b7db883e6ea0aa631490fb5f806c55ceea7cb5 by gns root@infi.wang:
[XLA:CPU] Add support for riscv64
Co-authored-by: Levi Zim rsworktech@outlook.com
--
a00c3a3ba94664798960cbc2fb0a6746fe0c3ac1 by gns root@infi.wang:
Add missing llvm:: namespace qualifiers for DTensor
Add the
llvm::namespace prefix tocastandisawhere it was missing in the DTensor MLIR code.
--
febc5abc56ab302f5f39fe20176ed00c0c95cb7e by gns root@infi.wang:
runtime: add missing stdint header
Co-authored-by: Levi Zim rsworktech@outlook.com
--
6bf63fec56a6d961b06d932fe69b76eae89d8cb7 by gns root@infi.wang:
Add riscv64 support patch for rules_python
bazel-contrib/rules_python#3350
--
68c44fa9613d5577f36c51a192c932795e13ed83 by gns root@infi.wang:
tools: py: add riscv64 to pip and manylinux compilance test
--
3f2fe1e0256476449f64658219d997727c9cc534 by gns root@infi.wang:
Lift timeout of rules_python for BFS wheels
--
252a9b7ad2336b7abbb94e269b4a976b45d5d6e7 by gns root@infi.wang:
Revert llvm toolchain patch for riscv64
As already upstreamed.
Co-authored-by: Levi Zim rsworktech@outlook.com
--
51047a86131e991ffea74fccb8f55e3521237a64 by gns root@infi.wang:
Lift timeout for BFS wheels during pip init
--
3b8276420031969423c9a1f150341a0e41fa372e by gns root@infi.wang:
Refresh
rules_pythonriscv64 patchCo-authored-by: Levi Zim rsworktech@outlook.com
Merging this change closes #102607
FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#102607 from infiWang:riscv64 3b8276420031969423c9a1f150341a0e41fa372e