Skip to content

[openwrt-19.07] python3-maxminddb: Fix build when using newer setuptools#12756

Merged
neheb merged 1 commit intoopenwrt:openwrt-19.07from
jefferyto:python3-maxminddb-fix-build-openwrt-19.07
Jul 8, 2020
Merged

[openwrt-19.07] python3-maxminddb: Fix build when using newer setuptools#12756
neheb merged 1 commit intoopenwrt:openwrt-19.07from
jefferyto:python3-maxminddb-fix-build-openwrt-19.07

Conversation

@jefferyto
Copy link
Member

Maintainer: @ja-pa
Compile tested: armvirt-64, 19.07.3 sdk (combined with #12755)
Run tested: none

Description:
This package fails to build with newer setuptools, because setuptools removed the (deprecated) Features feature in v46.0.0.

This adapts a commit to remove the use of this feature. (Changes to code formatting prevent the original commit/patch to be used.)

Signed-off-by: Jeffery To jeffery.to@gmail.com

This package fails to build with newer setuptools, because setuptools
removed the (deprecated) Features feature in v46.0.0[1].

This adapts a commit[2] to remove the use of this feature. (Changes to
code formatting prevent the original commit/patch to be used.)

[1]: https://github.com/pypa/setuptools/blob/aff64ae89e00e25fb3868bf528a14c18e7af0cf4/CHANGES.rst#v4600
[2]: maxmind/MaxMind-DB-Reader-python@3aac426

Signed-off-by: Jeffery To <jeffery.to@gmail.com>
@ja-pa
Copy link
Contributor

ja-pa commented Jul 8, 2020

LGTM
Thx, I just run tested it on Omnia with 19.07

@neheb neheb merged commit 5c4ead1 into openwrt:openwrt-19.07 Jul 8, 2020
@jefferyto jefferyto deleted the python3-maxminddb-fix-build-openwrt-19.07 branch July 9, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants