Skip to content

[CPU] Fixed Replicate via ov::Model#9252

Merged
dmitry-gorokhov merged 3 commits intoopenvinotoolkit:masterfrom
a-sidorova:fix/replicate_ngraph
Jan 10, 2022
Merged

[CPU] Fixed Replicate via ov::Model#9252
dmitry-gorokhov merged 3 commits intoopenvinotoolkit:masterfrom
a-sidorova:fix/replicate_ngraph

Conversation

@a-sidorova
Copy link
Copy Markdown
Contributor

@a-sidorova a-sidorova commented Dec 16, 2021

Details:

  • TensorIterator and If have bodies that use Replicate via ov::Model. But if there is op with unused output ports inside body, information about these ports is lost in this line: op2node[op->output(oi).get_node_shared_ptr()] = {node, outPortIdx++};. So I aligned behavior Replicate via ov::Model like via CNNNetwork
  • Added test with the same body in If

Tickets:

  • N/A

@a-sidorova a-sidorova marked this pull request as ready for review December 16, 2021 07:37
@a-sidorova a-sidorova requested review from a team December 16, 2021 07:37
@a-sidorova a-sidorova added the category: CPU OpenVINO CPU plugin label Dec 16, 2021
@a-sidorova a-sidorova added this to the 2022.1 milestone Dec 16, 2021
@a-sidorova
Copy link
Copy Markdown
Contributor Author

@dmitry-gorokhov take a look please (case with NMS inside body)

@openvino-pushbot openvino-pushbot added the category: IE Tests OpenVINO Test: plugins and common label Dec 16, 2021
@a-sidorova a-sidorova force-pushed the fix/replicate_ngraph branch 2 times, most recently from 08920f0 to dea516e Compare December 23, 2021 21:45
@dmitry-gorokhov dmitry-gorokhov self-assigned this Dec 24, 2021
Copy link
Copy Markdown

@dmitry-gorokhov dmitry-gorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be merged after #8967

@dmitry-gorokhov
Copy link
Copy Markdown

@a-sidorova could you please rebase the PR on latest master?

@a-sidorova a-sidorova force-pushed the fix/replicate_ngraph branch from fcdfbe2 to e8e4076 Compare January 10, 2022 11:55
@a-sidorova a-sidorova requested a review from a team January 10, 2022 11:55
@dmitry-gorokhov dmitry-gorokhov enabled auto-merge (squash) January 10, 2022 12:16
@dmitry-gorokhov dmitry-gorokhov merged commit af105b8 into openvinotoolkit:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants