Skip to content

[IE CLDNN] Always use FP32 as intermediate type for fused quantize#829

Merged
vladimir-paramuzov merged 1 commit intoopenvinotoolkit:releases/2020/4from
vladimir-paramuzov:private/vparamuz/fix_tmp_type_in_fq
Jun 11, 2020
Merged

[IE CLDNN] Always use FP32 as intermediate type for fused quantize#829
vladimir-paramuzov merged 1 commit intoopenvinotoolkit:releases/2020/4from
vladimir-paramuzov:private/vparamuz/fix_tmp_type_in_fq

Conversation

@vladimir-paramuzov
Copy link
Copy Markdown

@vladimir-paramuzov vladimir-paramuzov commented Jun 8, 2020 •
edited
Loading

  • Used FP32 for intermediate calculation as the safest type
  • Fixed fused ops configuration in permute to have correct input type instead of unitType
  • Fixed activation type for fp16 convolutions - it was set to fp32 while actually input was fp16.

@vladimir-paramuzov vladimir-paramuzov added the category: GPU OpenVINO GPU plugin label Jun 8, 2020
@vladimir-paramuzov vladimir-paramuzov requested review from a team as code owners June 8, 2020 20:34
@vladimir-paramuzov vladimir-paramuzov self-assigned this Jun 8, 2020
@vladimir-paramuzov vladimir-paramuzov force-pushed the private/vparamuz/fix_tmp_type_in_fq branch from 9ef1de6 to edca19f Compare June 9, 2020 07:21
@vladimir-paramuzov vladimir-paramuzov changed the base branch from master to releases/2020/4 June 9, 2020 16:24
sshlyapn
sshlyapn approved these changes Jun 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sshlyapn sshlyapn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladimir-paramuzov vladimir-paramuzov mentioned this pull request Jun 10, 2020
Merged
@vladimir-paramuzov vladimir-paramuzov added this to the 2020.4 milestone Jun 10, 2020
@vladimir-paramuzov vladimir-paramuzov force-pushed the private/vparamuz/fix_tmp_type_in_fq branch from edca19f to caf0a73 Compare June 10, 2020 21:31
@vladimir-paramuzov vladimir-paramuzov merged commit 412428f into openvinotoolkit:releases/2020/4 Jun 11, 2020
@vladimir-paramuzov vladimir-paramuzov deleted the private/vparamuz/fix_tmp_type_in_fq branch June 15, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sshlyapn sshlyapn sshlyapn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vladimir-paramuzov vladimir-paramuzov

Labels

category: GPU OpenVINO GPU plugin

Projects

None yet

Milestone

2020.4

Development

Successfully merging this pull request may close these issues.

2 participants

@vladimir-paramuzov @sshlyapn