[OV2.0] Leftovers for Preprocessing/input/output#7893
Merged
ilya-lavrenov merged 4 commits intoopenvinotoolkit:masterfrom Oct 8, 2021
Merged
[OV2.0] Leftovers for Preprocessing/input/output#7893ilya-lavrenov merged 4 commits intoopenvinotoolkit:masterfrom
ilya-lavrenov merged 4 commits intoopenvinotoolkit:masterfrom
Conversation
| // layouts) | ||
| if (src_layout == dst) { | ||
| return {}; // No permutation is needed | ||
| } |
Contributor
There was a problem hiding this comment.
another option is to return 0 1 2 .. rank-1, but not sure which one is better. Your one maybe more easy to check for end users, but from math point of view NCHW -> NCHW is 0123
Contributor
Author
There was a problem hiding this comment.
Yes, when I'll implement dynamic conversion "NC??" to "NCHW" - result will be [0, 1, 2, 3] and probably I'll add some logic here to return empty array for this case (for easier check). Also this find_permutation is not exported for end user yet to have more freedom for us
- Implicit conversions for element type and layout - 'convert_element_type' with default argument to network - Convert_element_type - don't add ops if dst and src types are same - Convert_layout - don't add ops if dst and src layouts are same - Custom step - use Output<Node> instead of shared_ptr<Node> - Support of addressing input by tensor name Post-process: - Avoid duplication of tensor names after post-processing
# Conflicts: # ngraph/core/src/preprocess/preprocess_steps_impl.cpp
ilyachur
reviewed
Oct 8, 2021
| /// \brief Constructor for particular output of model addressed by it's input name | ||
| /// | ||
| /// \param input_tensor_name Name of input tensor name | ||
| explicit InputInfo(const std::string& input_tensor_name); |
Contributor
There was a problem hiding this comment.
Do we have tests for these constructors?
Contributor
Author
There was a problem hiding this comment.
Yes, it is covered by tests
ilya-lavrenov
approved these changes
Oct 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Pre-process:
Post-process:
Test coverage: 100%
Tickets: