Skip to content

Revert non-forward-compatible changes for PriorBox & PriorBoxClustered operations#4501

Merged
lazarevevgeny merged 7 commits intoopenvinotoolkit:masterfrom
achetver:fix/achetver/priorbox_bool_attrs
Mar 1, 2021
Merged

Revert non-forward-compatible changes for PriorBox & PriorBoxClustered operations#4501
lazarevevgeny merged 7 commits intoopenvinotoolkit:masterfrom
achetver:fix/achetver/priorbox_bool_attrs

Conversation

@achetver
Copy link
Copy Markdown
Contributor

Details:

  • Revert changes for some attributes values in IR from true/false to 1/0 because IE 2021.2 cannot read this values.

Tickets:

  • 49897

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests: N/A - No new implemented functions;
  • Framework operation tests: N/A - No new enabled operations;
  • Transformation tests: N/A - No new implemented transformations;
  • Model Optimizer IR Reader check: Done manually.

Documentation:

  • Supported frameworks operations list: N/A - No new supported operations;
  • Supported public models list: N/A - Nothing to add;
  • User guide update: N/A - Nothing to update.

@achetver achetver added the category: MO Model Optimizer label Feb 26, 2021
@achetver achetver added this to the 2021.3 milestone Feb 26, 2021
@achetver achetver requested review from a team, evolosen, iimironov and pavel-esir and removed request for a team February 26, 2021 13:16
@achetver achetver marked this pull request as ready for review February 26, 2021 13:16
@achetver achetver requested a review from a team as a code owner February 26, 2021 13:16
@achetver achetver requested a review from a team February 26, 2021 13:16
@achetver
Copy link
Copy Markdown
Contributor Author

@pavel-esir @iimironov @evolosen please, review these changes.

Copy link
Copy Markdown
Contributor

@pavel-esir pavel-esir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Personally @achetver explained why these changes are needed.

@achetver
Copy link
Copy Markdown
Contributor Author

achetver commented Mar 1, 2021

@lazarevevgeny This PR is ready for your review.

@lazarevevgeny lazarevevgeny merged commit 96875ef into openvinotoolkit:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: MO Model Optimizer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants