Removed hardcoded shapes from LogSoftmax operation#4475
Merged
ilyachur merged 4 commits intoopenvinotoolkit:masterfrom Feb 25, 2021
Merged
Removed hardcoded shapes from LogSoftmax operation#4475ilyachur merged 4 commits intoopenvinotoolkit:masterfrom
ilyachur merged 4 commits intoopenvinotoolkit:masterfrom
Conversation
Contributor
Author
|
@tomdol I didn't find a place to add new tests for this change. Do we have tests which check that we can reshape nGraph function after the ONNX importer? |
tomdol
approved these changes
Feb 25, 2021
Contributor
|
This is tested in e2e tests but not per-op, it's done per-model and I'm not sure if LogSoftmax is used in any of them. Let me check the code and get back to you about it. |
Contributor
Author
|
@tomdol I added new tests. Please have a look. |
e-nugmanova
approved these changes
Feb 25, 2021
tomdol
reviewed
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: