[LPT] integrated fixes for release 2021.3#4460
Merged
azhogov merged 8 commits intoopenvinotoolkit:masterfrom Feb 25, 2021
Merged
[LPT] integrated fixes for release 2021.3#4460azhogov merged 8 commits intoopenvinotoolkit:masterfrom
azhogov merged 8 commits intoopenvinotoolkit:masterfrom
Conversation
b26d5ef to
62d73e1
Compare
63e154a to
4b86a79
Compare
v-Golubev
approved these changes
Feb 24, 2021
vzinovie
approved these changes
Feb 24, 2021
| } | ||
|
|
||
| int NetworkHelper::getConstantInputIndex(std::shared_ptr<Node> node) { | ||
| if (as_type_ptr<opset1::Constant>(node->get_input_node_shared_ptr(1)) != nullptr) { |
Contributor
There was a problem hiding this comment.
minor: Maybe we should use ngraph::is_type for such checks?
| return 1; | ||
| } | ||
|
|
||
| if (as_type_ptr<opset1::Constant>(node->get_input_node_shared_ptr(0)) != nullptr) { |
|
|
||
| auto const values = multiplyConstant->cast_vector<float>(); | ||
| return std::any_of(values.begin(), values.end(), [](const float value) { return value == 0.f; }); | ||
| return std::any_of(values.begin(), values.end(), [](const float value) { return (value == 0.f) || (std::abs(value) < 1.e-32); }); |
Contributor
There was a problem hiding this comment.
minor: Let's handle 0/0 like 0 value. Actually it's even not handled in master because of value == 0.f.
Contributor
There was a problem hiding this comment.
minor: This code still have to be modified to be able to pass Multiply(0) -> Add(0) cases.
|
When this PR will be merged in master? |
2b4dcd3 to
2501c97
Compare
Author
vzinovie
approved these changes
Feb 25, 2021
This was referenced Feb 25, 2021
This was referenced Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
validation:
validation:
validation: