Skip to content

Reset Variable to dynamic state in revalidate_and_infer function of ReadValue op#4430

Merged
ilyachur merged 1 commit intoopenvinotoolkit:masterfrom
itikhono:itikhono/fix/kaldi_batch_2
Feb 26, 2021
Merged

Reset Variable to dynamic state in revalidate_and_infer function of ReadValue op#4430
ilyachur merged 1 commit intoopenvinotoolkit:masterfrom
itikhono:itikhono/fix/kaldi_batch_2

Conversation

@itikhono
Copy link
Copy Markdown
Contributor

@itikhono itikhono commented Feb 19, 2021

Details:

    • Reset Variable to dynamic state in revalidate_and_infer function of ReadValue op. We need to store the state (shape and type) of Variables between inferences (or between evaluate calls), but in some scenarios such as calling the reshape() of CNN Network, we need to drop shape and type and set them to dynamic. *

Tickets:

  • 49217

@itikhono itikhono added this to the 2021.3 milestone Feb 19, 2021
@itikhono itikhono requested a review from a team February 19, 2021 17:18
@itikhono itikhono added the bug Something isn't working label Feb 19, 2021
@openvino-pushbot openvino-pushbot added the category: Core OpenVINO Core (aka ngraph) label Feb 19, 2021
ilyachur
ilyachur reviewed Feb 20, 2021
View reviewed changes
@ilyachur
Copy link
Copy Markdown
Contributor

ilyachur commented Feb 20, 2021

Can we add new tests to cover this functionality?

@ilyachur ilyachur added the pr: needs tests PR needs tests updating label Feb 20, 2021
@ilyachur ilyachur merged commit 7cf7e1b into openvinotoolkit:master Feb 26, 2021
@e-nugmanova e-nugmanova mentioned this pull request Feb 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GlebKazantaev GlebKazantaev Awaiting requested review from GlebKazantaev

2 more reviewers

@ilyachur ilyachur ilyachur approved these changes

@e-nugmanova e-nugmanova e-nugmanova approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GlebKazantaev GlebKazantaev

@e-nugmanova e-nugmanova

Labels

bug Something isn't working category: Core OpenVINO Core (aka ngraph) pr: needs tests PR needs tests updating

Projects

None yet

Milestone

2021.3

Development

Successfully merging this pull request may close these issues.

5 participants

@itikhono @ilyachur @GlebKazantaev @e-nugmanova @openvino-pushbot