Fix NonZero output shape inference for static inputs.#4406
Merged
e-nugmanova merged 6 commits intoopenvinotoolkit:masterfrom Mar 1, 2021
Merged
Conversation
Contributor
Author
|
@GlebKazantaev @ilyachur we can't serialize PyTorch_MaskRCNN_ResNet50_FPN_wo_cfg_wo_infer_batch_1_device_CPU_fusing_True_precision because of NonZero op with dynamic dimension which can't be converted to static (it doesn't have upper_bound) . When I set upper_bound to some arbitrary value serialization works. Should we mark this test as expected to fail? Or maybe we should use some arbitrary value for upper_bound in such cases? Any ideas ? |
e-nugmanova
suggested changes
Feb 24, 2021
inference-engine/src/transformations/src/transformations/serialize.cpp
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I run serialization test suite on this PR and it confirm that issue with NonZero serialization is resolved. |
Contributor
Author
|
@jane-intel please re-review. Do you want to run additional tests on this PR as you mentioned before? |
ilyachur
approved these changes
Mar 1, 2021
e-nugmanova
approved these changes
Mar 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket. 29898. Serialization fails for NonZero op because it contain dynamic dimension which cannot be resolved (no upper bound). Improved error message for this case.