Fix output names for group of Strided Slices to Variadic Split optimization#4378
Merged
GlebKazantaev merged 5 commits intoopenvinotoolkit:masterfrom Feb 25, 2021
Merged
Conversation
ilyachur
reviewed
Feb 18, 2021
| if (record.first != fake_output) { | ||
| const auto out_name = record.first.get_node_shared_ptr()->get_friendly_name(); | ||
| NGRAPH_SUPPRESS_DEPRECATED_START | ||
| variadic_split->get_output_tensor(i).set_name(out_name); |
Contributor
There was a problem hiding this comment.
It is a WA.
Can we use the new API?
It should allow to map framework names to OV names without work arounds on the transformations side.
ilyachur
approved these changes
Feb 18, 2021
Contributor
ilyachur
left a comment
There was a problem hiding this comment.
We used the same WA for the TI at the current moment, but honesty I highly recommend to use the new API because we have a plan to remove get/set_name().
tomdol
approved these changes
Feb 18, 2021
Contributor
tomdol
left a comment
There was a problem hiding this comment.
LGTM but please test the new API as suggested above. It can be done separately and used in a separate PR.
mbencer
approved these changes
Feb 18, 2021
Contributor
|
Please do not merge, I still have some concerns that I wan to discuss with @ilyachur today. |
GlebKazantaev
suggested changes
Feb 18, 2021
...gine/src/transformations/src/transformations/common_optimizations/optimize_strided_slice.cpp
Outdated
Show resolved
Hide resolved
…into VariadicSplitOutputNames
tsocha
approved these changes
Feb 23, 2021
ilyachur
approved these changes
Feb 24, 2021
GlebKazantaev
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Group of StridedSlice operators is optimized to single VariadicSplit operator with multiple outputs, but output names are not retained.
This can cause problems when these outputs are also the outputs of the entire model.
Tickets:
43277