Skip to content

[MO][TF] Fixed TFSliceToSlice conversion error on Win#4367

Merged
azhogov merged 7 commits intoopenvinotoolkit:masterfrom
pavel-esir:tfslice_fix
Feb 24, 2021
Merged

[MO][TF] Fixed TFSliceToSlice conversion error on Win#4367
azhogov merged 7 commits intoopenvinotoolkit:masterfrom
pavel-esir:tfslice_fix

Conversation

@pavel-esir
Copy link
Copy Markdown
Contributor

Description: on Windows with some versions of numpy by default int32 array was created and this caused error on Select node. Since Select expects inputs with the same dtypes. Fixed by changing max int32 to ShapeOf.

Tickets:
43274, 45388

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests
  • Framework operation tests: no new operations were added, verified changes on deeplabv3 model
  • Transformation tests
  • Model Optimizer IR Reader check

Documentation:

  • Supported frameworks operations list: N/A for this changes, but some correction for similar ops have been done
  • Guide on how to convert the public model: N/A does not affect model conversion process
  • User guide update: N/A bugfix does not introduce changes in use scenarios

…_max with ShapeOf, minor correction in comments
@pavel-esir pavel-esir added the bug Something isn't working label Feb 16, 2021
@pavel-esir pavel-esir added this to the 2021.3 milestone Feb 16, 2021
@pavel-esir pavel-esir requested a review from a team as a code owner February 16, 2021 13:18
@pavel-esir pavel-esir requested a review from a team February 16, 2021 13:18
@openvino-pushbot openvino-pushbot added category: docs OpenVINO documentation category: MO Model Optimizer labels Feb 16, 2021
@pavel-esir pavel-esir mentioned this pull request Feb 16, 2021
14 tasks
@pavel-esir pavel-esir requested a review from mvafin February 18, 2021 10:18
@pavel-esir
Copy link
Copy Markdown
Contributor Author

@mvafin @rkazants thanks a lot for your comments. Replied to them. Please review

@pavel-esir pavel-esir requested a review from rkazants February 18, 2021 17:02
@azhogov
Copy link
Copy Markdown

azhogov commented Feb 24, 2021

@azhogov azhogov merged commit 162bdde into openvinotoolkit:master Feb 24, 2021
@pavel-esir pavel-esir deleted the tfslice_fix branch February 28, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working category: docs OpenVINO documentation category: MO Model Optimizer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants