Skip to content

Fixed github issue #4172#4201

Merged
ilya-lavrenov merged 3 commits intoopenvinotoolkit:masterfrom
ilya-lavrenov:github-issue-4172
Feb 8, 2021
Merged

Fixed github issue #4172#4201
ilya-lavrenov merged 3 commits intoopenvinotoolkit:masterfrom
ilya-lavrenov:github-issue-4172

Conversation

@ilya-lavrenov
Copy link
Copy Markdown
Contributor

No description provided.

@ilya-lavrenov ilya-lavrenov added category: IE Tests OpenVINO Test: plugins and common category: VPU labels Feb 5, 2021
@ilya-lavrenov ilya-lavrenov requested a review from a team as a code owner February 5, 2021 10:23
@ilya-lavrenov ilya-lavrenov requested a review from a team February 5, 2021 10:23
@ilya-lavrenov ilya-lavrenov requested a review from a team as a code owner February 5, 2021 10:23
@openvino-pushbot openvino-pushbot added the category: docs OpenVINO documentation label Feb 5, 2021
const auto executableNetwork =
std::make_shared<ExecutableNetwork>(
model, _mvnc, _devicePool, parsedConfigCopy, GetCore());
executableNetwork->SetPointerToPlugin(shared_from_this());
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the Myriad plugin has such an issue? Or maybe we need to add this line to the common part, as for the InferencePluginInternal::LoadNetwork?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoadNetwork has common implementation, while ImportNetwork does not..

Maybe KMB also has such issue, but need to enable tests separately and check.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see, no plugin calls the SetPointerToPlugin method while import network. Is not it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Template and Hetero plugins do it. Need to enable these tests on other plugins (KMB, GNA) and fix the issue if it's here.

Copy link
Copy Markdown
Contributor

@nikita-kud nikita-kud Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we need ticket for these plugins. And common solution would look better, but I don't insist

Comment thread inference-engine/tests/functional/plugin/shared/src/behavior/cpp_holders.cpp Outdated
@ilya-lavrenov ilya-lavrenov added this to the 2021.3 milestone Feb 5, 2021
@nikita-kud nikita-kud self-requested a review February 5, 2021 13:07
Copy link
Copy Markdown
Contributor

@nikita-kud nikita-kud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM

@ilya-lavrenov ilya-lavrenov merged commit 500df58 into openvinotoolkit:master Feb 8, 2021
@ilya-lavrenov ilya-lavrenov deleted the github-issue-4172 branch February 8, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: docs OpenVINO documentation category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] InferenceEngine::Core::ImportNetwork() returns unusable object

3 participants