Skip to content

[IE][VPU]: Enables Loop Support#4157

Merged
Maxim-Doronin merged 6 commits intoopenvinotoolkit:masterfrom
ggladilov:vpu/gg/enables-loop-support
Feb 5, 2021
Merged

[IE][VPU]: Enables Loop Support#4157
Maxim-Doronin merged 6 commits intoopenvinotoolkit:masterfrom
ggladilov:vpu/gg/enables-loop-support

Conversation

@ggladilov
Copy link
Copy Markdown
Contributor

Descirption

  • Enables StaticShapeLoop -> CNN conversion as TensorIterator
  • Enables visit_attributes API for StaticShapeLoop
  • Enables Loop support in TensorIterator parser
  • Fixes LoopStart/LoopEnd serialization
  • Fixes dynamic iterations count for LoopEnd
  • Updates firmware on Loop fixes

Task

#-45342

@ggladilov ggladilov added this to the 2021.3 milestone Feb 3, 2021
@ggladilov ggladilov requested review from a user, Maxim-Doronin and andrejsokolov February 3, 2021 10:07
@ggladilov ggladilov requested a review from a team February 3, 2021 10:07
@ggladilov ggladilov requested a review from a team as a code owner February 3, 2021 10:07
@ggladilov ggladilov requested a review from a team February 3, 2021 10:07
@openvino-pushbot openvino-pushbot added category: inference OpenVINO Runtime library - Inference category: Core OpenVINO Core (aka ngraph) labels Feb 3, 2021
Signed-off-by: Gladilov, Gleb <gleb.gladilov@intel.com>
Signed-off-by: Gladilov, Gleb <gleb.gladilov@intel.com>
Signed-off-by: Gladilov, Gleb <gleb.gladilov@intel.com>
Signed-off-by: Gladilov, Gleb <gleb.gladilov@intel.com>
In general approach is to keep index of data which shape
contains dimension of length equal to iterations count.
Current version is fixed to use batch of such dimension
in shape.

Previous version index for input data object for
both LoopStart and LoopEnd.

While for LoopStart it is correct behavior, for LoopEnd
it is wrong. The reason is LoopStart has "big" data on
input and single slice on output, LoopEnd has slice on
input and "big" data on output. As a result, LoopEnd
saw iterations count as 1 (taking batch from slice
instead of complete chunk) in dynamic case and copied
each iteration result to first slice of output leaving
all others uninitialized.

Signed-off-by: Gladilov, Gleb <gleb.gladilov@intel.com>
Signed-off-by: Gladilov, Gleb <gleb.gladilov@intel.com>
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GlebKazantaev GlebKazantaev removed the request for review from a team February 4, 2021 20:12
@Maxim-Doronin Maxim-Doronin merged commit 90347c2 into openvinotoolkit:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: Core OpenVINO Core (aka ngraph) category: inference OpenVINO Runtime library - Inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants