Skip to content

Group convolution backprop data#4113

Merged
iefode merged 18 commits intoopenvinotoolkit:masterfrom
jdanieck:group_convolution_backprop_data
Feb 8, 2021
Merged

Group convolution backprop data#4113
iefode merged 18 commits intoopenvinotoolkit:masterfrom
jdanieck:group_convolution_backprop_data

Conversation

@jdanieck
Copy link
Copy Markdown
Contributor

@jdanieck jdanieck commented Feb 1, 2021

GroupConvolutionBackpropData reference implementation developed. Ticket 37444.

Implementation details:

  • Reused runtime::reference::convolution_backprop_in() for actual operation calculation
  • Removed GroupConvolutionBackpropData from int_executable
  • Added GroupConvolutionBackpropData to evaluates_map
  • SLT tests extended by 1-D GroupConvolutionBackpropData tests
  • Serialization SLT added
  • Specification refactored
  • Ngraph operation refactored

@ggalieroc-zz ggalieroc-zz marked this pull request as ready for review February 4, 2021 15:35
@ggalieroc-zz ggalieroc-zz requested a review from a team as a code owner February 4, 2021 15:35
@ggalieroc-zz ggalieroc-zz requested review from a team February 4, 2021 15:35
@GlebKazantaev GlebKazantaev removed the request for review from a team February 4, 2021 20:53
@ggalieroc-zz ggalieroc-zz requested a review from iefode February 5, 2021 08:51
@ggalieroc-zz ggalieroc-zz added the category: Core OpenVINO Core (aka ngraph) label Feb 5, 2021
@ggalieroc-zz ggalieroc-zz self-assigned this Feb 5, 2021
@jdanieck jdanieck requested a review from iefode February 7, 2021 15:06
@jdanieck
Copy link
Copy Markdown
Contributor Author

jdanieck commented Feb 8, 2021

@lazarevevgeny following the convention from previous PRs please look at the spec - it is written by me, I followed already established conventions. Ilya already approved, so we're waiting for you and then we can merge.

Copy link
Copy Markdown
Contributor

@iefode iefode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE Test part LGTM

@iefode iefode merged commit 0acd153 into openvinotoolkit:master Feb 8, 2021
@jdanieck jdanieck deleted the group_convolution_backprop_data branch June 16, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: Core OpenVINO Core (aka ngraph)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants