Skip to content

Tensor names in IR#4089

Merged
lazarevevgeny merged 18 commits intoopenvinotoolkit:masterfrom
popovaan:tensor-names-in-ir
Feb 6, 2021
Merged

Tensor names in IR#4089
lazarevevgeny merged 18 commits intoopenvinotoolkit:masterfrom
popovaan:tensor-names-in-ir

Conversation

@popovaan
Copy link
Copy Markdown
Contributor

@popovaan popovaan commented Jan 29, 2021 •
edited
Loading

Description: Added modes of saving "fw_tensor_debug_info" attributes in reconnect functions. Made default "merge" mode for saving attributes. Added saving tensor names to IR.

JIRA: 46604

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests
  • Framework operation tests - N/A
  • Transformation tests - N/A
  • e2e model test with an update of ./tests/e2e_oss/utils/reshape_utils.py - N/A
  • Model Optimizer IR Reader check

Documentation:

  • Supported frameworks operations list - N/A
  • Supported public models list - N/A
  • New operations specification - N/A
  • Guide on how to convert the public model - N/A
  • User guide update - N/A

@popovaan popovaan requested a review from a team January 29, 2021 13:43
@openvino-pushbot openvino-pushbot added the category: MO Model Optimizer label Jan 29, 2021
@popovaan popovaan requested review from a team, evolosen, lazarevevgeny, mvafin and pavel-esir and removed request for a team January 29, 2021 14:21
lazarevevgeny
lazarevevgeny suggested changes Jan 31, 2021
View reviewed changes
sadolini
sadolini suggested changes Feb 4, 2021
View reviewed changes
@popovaan popovaan requested a review from sadolini February 4, 2021 11:00
sadolini
sadolini suggested changes Feb 5, 2021
View reviewed changes
@achetver achetver mentioned this pull request Feb 5, 2021
Merged
14 tasks
pavel-esir
pavel-esir approved these changes Feb 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@pavel-esir pavel-esir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lazarevevgeny lazarevevgeny merged commit cfc3b56 into openvinotoolkit:master Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavel-esir pavel-esir pavel-esir approved these changes

@mvafin mvafin mvafin approved these changes

+4 more reviewers

@iimironov iimironov iimironov approved these changes

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

@sadolini sadolini sadolini approved these changes

@evolosen evolosen evolosen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: MO Model Optimizer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@popovaan @pavel-esir @mvafin @iimironov @lazarevevgeny @sadolini @evolosen @openvino-pushbot