Skip to content

Add CTCGreedyDecoder mo support#4009

Merged
lazarevevgeny merged 85 commits intoopenvinotoolkit:masterfrom
iimironov:imironov/extend-mo-ctc-greedy-decoder
Feb 17, 2021
Merged

Add CTCGreedyDecoder mo support#4009
lazarevevgeny merged 85 commits intoopenvinotoolkit:masterfrom
iimironov:imironov/extend-mo-ctc-greedy-decoder

Conversation

@iimironov
Copy link
Copy Markdown
Contributor

@iimironov iimironov commented Jan 25, 2021

Ticket 42642
Description: Extend CTCGreedyDecoderSeqLen for MO. Add transformation CTCGreedyDecoder from v6 to v1.

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests
  • Framework operation tests - we have a separate testing activity
  • Transformation tests
  • e2e model test we have a separate testing activity
  • Model Optimizer IR Reader check

Documentation:

  • Supported frameworks operations: ticket 42644
  • Supported public models list - N/A
  • New operations specification: ticket 42641
  • Guide on how to convert the public model - N/A
  • User guide update - N/A

@iimironov iimironov requested a review from a team January 25, 2021 18:45
@openvino-pushbot openvino-pushbot added the category: MO Model Optimizer label Jan 25, 2021
@iimironov iimironov requested review from a team January 28, 2021 11:29
@GlebKazantaev
Copy link
Copy Markdown
Contributor

Please add more detailed description.

@iimironov iimironov requested review from a team February 2, 2021 16:10
@GlebKazantaev
Copy link
Copy Markdown
Contributor

GlebKazantaev commented Feb 15, 2021

@lazarevevgeny @andrei-kochin Discussed in offline with @iimironov that as this transformation needed only for private plugin we will move source code directly to this plugin and leave transformation library without changes.

@lazarevevgeny
Copy link
Copy Markdown
Contributor

@rkazants , your approval is needed.

Copy link
Copy Markdown
Collaborator

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have some fixes request

@iimironov iimironov requested a review from rkazants February 16, 2021 10:25
@lazarevevgeny lazarevevgeny merged commit f670b7c into openvinotoolkit:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: MO Model Optimizer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants