Skip to content

Serialization dynamic layer bug#3982

Merged
ilyachur merged 19 commits intoopenvinotoolkit:masterfrom
bszmelcz:SerializationDynamicLayerBug
Feb 4, 2021
Merged

Serialization dynamic layer bug#3982
ilyachur merged 19 commits intoopenvinotoolkit:masterfrom
bszmelcz:SerializationDynamicLayerBug

Conversation

@bszmelcz
Copy link
Copy Markdown
Contributor

@bszmelcz bszmelcz commented Jan 22, 2021

Fix serialization for graphs with last dynamic layer not connected to Results.

Ticket 45199.

@jdanieck jdanieck marked this pull request as ready for review January 27, 2021 09:14
@jdanieck
Copy link
Copy Markdown
Contributor

The check is removed and CI is green. Looks ready to merge.

@jdanieck jdanieck requested a review from ilyachur January 27, 2021 09:15
@bszmelcz
Copy link
Copy Markdown
Contributor Author

@ilyachur, I tried to implement the changes with disable reshape as we discussed yesterday. It turned out that in order to use GenericIE in serialization file I need to add plugin_api to cmake. Does it changes something or is it ok to add this dependency?

@ilyachur
Copy link
Copy Markdown
Contributor

Could you please add new tests to cover this bug?

@ilyachur ilyachur added this to the 2021.3 milestone Jan 27, 2021
@ilyachur ilyachur added bug Something isn't working category: transformations OpenVINO Runtime library - Transformations pr: needs tests PR needs tests updating labels Jan 27, 2021
@jdanieck
Copy link
Copy Markdown
Contributor

Could you please add new tests to cover this bug?

The initial report says it will be issue with NMS. So @bszmelcz let's try to reproduce this issue with NMS by introducing Serialization SLT for it, and then check if your fix is resolving issue.

Hi, I realized that we merged #3475 but the fix was actually wrong because node->is_dynamic() method checks only input shapes but not output. So it won’t work for NMS which always produce dynamic output shape. I think we need to remove this check at all.

@GlebKazantaev
Copy link
Copy Markdown
Contributor

Could you please add new tests to cover this bug?

The initial report says it will be issue with NMS. So @bszmelcz let's try to reproduce this issue with NMS by introducing Serialization SLT for it, and then check if your fix is resolving issue.

Hi, I realized that we merged #3475 but the fix was actually wrong because node->is_dynamic() method checks only input shapes but not output. So it won’t work for NMS which always produce dynamic output shape. I think we need to remove this check at all.

I wasn't right about removing this check at all. See my comment above.

@bszmelcz bszmelcz requested a review from a team January 29, 2021 13:08
@bszmelcz
Copy link
Copy Markdown
Contributor Author

@GlebKazantaev I added the SLT for serialization for NMS, but it seems like that all the tests are passing. Could you give me some hint what might be wrong, since I cannot reproduce the bug?

@jdanieck jdanieck removed the pr: needs tests PR needs tests updating label Feb 3, 2021
@jdanieck
Copy link
Copy Markdown
Contributor

jdanieck commented Feb 3, 2021

@ilyachur I think we can merge, reported issue was reproduced with test and fixed. Additionally we got Serialization SLT for NMS op.

@ilyachur ilyachur merged commit 18a65b5 into openvinotoolkit:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working category: transformations OpenVINO Runtime library - Transformations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants