Merged
Conversation
added 13 commits
January 17, 2021 17:49
This reverts commit 739065d.
elszkowski
reviewed
Jan 21, 2021
ngraph/core/reference/include/ngraph/runtime/reference/convolution_backprop_data.hpp
Show resolved
Hide resolved
ngraph/core/reference/include/ngraph/runtime/reference/convolution_backprop_data.hpp
Show resolved
Hide resolved
ngraph/core/reference/include/ngraph/runtime/reference/convolution.hpp
Outdated
Show resolved
Hide resolved
ngraph/core/reference/include/ngraph/runtime/reference/convolution.hpp
Outdated
Show resolved
Hide resolved
ngraph/core/reference/include/ngraph/runtime/reference/convolution.hpp
Outdated
Show resolved
Hide resolved
ngraph/core/reference/include/ngraph/runtime/reference/convolution_backprop_data.hpp
Show resolved
Hide resolved
ngraph/core/reference/include/ngraph/runtime/reference/convolution_backprop_data.hpp
Show resolved
Hide resolved
ngraph/core/reference/include/ngraph/runtime/reference/convolution_backprop_data.hpp
Show resolved
Hide resolved
blesniewski
reviewed
Jan 22, 2021
ngraph/core/reference/include/ngraph/runtime/reference/convolution.hpp
Outdated
Show resolved
Hide resolved
blesniewski
approved these changes
Jan 25, 2021
elszkowski
approved these changes
Jan 27, 2021
ngraph/core/reference/include/ngraph/runtime/reference/convolution.hpp
Outdated
Show resolved
Hide resolved
lazarevevgeny
suggested changes
Jan 28, 2021
jdanieck
commented
Jan 28, 2021
jdanieck
commented
Jan 29, 2021
ngraph/core/reference/include/ngraph/runtime/reference/convolution.hpp
Outdated
Show resolved
Hide resolved
lazarevevgeny
approved these changes
Jan 31, 2021
This was referenced Jan 31, 2021
ilyachur
approved these changes
Feb 1, 2021
Contributor
Author
|
@ilyachur ready to merge. |
Contributor
|
Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convolution reference implementation refactored. Ticket 37429.
The easiest way to understand implementation is to start with 1D Convolution, then 2D and 3D. If you are not familiar with Convolution concepts (channels, strides, padding, dilation) I suggest to read articles attached to the ticket first.
Implementation details: