Skip to content

[IE][VPU]: Fixes BinaryEltwise DTS on empty input#3879

Merged
Maxim-Doronin merged 2 commits intoopenvinotoolkit:masterfrom
ggladilov:vpu/gg/fixes-binary-eltwise-dts-on-empty-input
Feb 8, 2021
Merged

[IE][VPU]: Fixes BinaryEltwise DTS on empty input#3879
Maxim-Doronin merged 2 commits intoopenvinotoolkit:masterfrom
ggladilov:vpu/gg/fixes-binary-eltwise-dts-on-empty-input

Conversation

@ggladilov
Copy link
Copy Markdown
Contributor

@ggladilov ggladilov commented Jan 15, 2021

Description

Makes DTS for BinaryEltwise produce empty output tensor in case if at least one input is empty. As a criteria for empty tensor ReduceMin is used (assuming all shape's values are non-negative).

Tests are changed accordingly. Trying to add new test case on inference with empty input, reference version failed, so those tests are left unchanged.

Task

#-46858

@ggladilov ggladilov added this to the 2021.3 milestone Jan 15, 2021
@ggladilov ggladilov requested review from a user and andrejsokolov January 15, 2021 13:37
@ggladilov ggladilov assigned ghost Jan 15, 2021
@ggladilov ggladilov requested a review from a team January 15, 2021 13:37
@ggladilov ggladilov requested a review from a team as a code owner January 15, 2021 13:37
@openvino-pushbot openvino-pushbot added the category: IE Tests OpenVINO Test: plugins and common label Jan 15, 2021
@ggladilov
Copy link
Copy Markdown
Contributor Author

ggladilov commented Jan 22, 2021

@andrejsokolov @AndrewBakalinIntel ping

ghost
ghost reviewed Jan 22, 2021
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add a couple of tests on inference?

@ggladilov
Copy link
Copy Markdown
Contributor Author

ggladilov commented Jan 22, 2021

Could you please also add a couple of tests on inference?

I tried to add some inference tests with empty input, but reference implementation failed for some reason on those cases (discussed offline with @itikhono).

@mikhail-treskin do you know anything about it? Should I raise a ticket on this?

@ggladilov ggladilov requested a review from a user January 22, 2021 16:29
@ggladilov
Copy link
Copy Markdown
Contributor Author

ggladilov commented Feb 1, 2021

Could you please also add a couple of tests on inference?

I tried to add some inference tests with empty input, but reference implementation failed for some reason on those cases (discussed offline with @itikhono).

@mikhail-treskin do you know anything about it? Should I raise a ticket on this?

@mikhail-treskin ping

ghost
ghost reviewed Feb 4, 2021
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update copyrights as well.

@ghost
Copy link
Copy Markdown

ghost commented Feb 4, 2021

Could you please also add a couple of tests on inference?

I tried to add some inference tests with empty input, but reference implementation failed for some reason on those cases (discussed offline with @itikhono).

@mikhail-treskin do you know anything about it? Should I raise a ticket on this?

Do you mean static cases or dynamic? Or they both failed?

@ggladilov
Copy link
Copy Markdown
Contributor Author

ggladilov commented Feb 4, 2021

Could you please also add a couple of tests on inference?

I tried to add some inference tests with empty input, but reference implementation failed for some reason on those cases (discussed offline with @itikhono).
@mikhail-treskin do you know anything about it? Should I raise a ticket on this?

Do you mean static cases or dynamic? Or they both failed?

Dynamic

@ggladilov ggladilov requested review from a team February 5, 2021 11:52
@ggladilov
Copy link
Copy Markdown
Contributor Author

ggladilov commented Feb 5, 2021

@andrejsokolov please take a look

@ggladilo
[IE][VPU]: Fixes BinaryEltwise DTS on empty input
a8312a4 
Signed-off-by: Gladilov, Gleb <gleb.gladilov@intel.com>
@ggladilo
[IE][VPU]: Updates firmware on empty input fixes for PostOps
13bae96 
Signed-off-by: Gladilov, Gleb <gleb.gladilov@intel.com>
@Maxim-Doronin Maxim-Doronin merged commit 785828d into openvinotoolkit:master Feb 8, 2021
@ggladilov ggladilov deleted the vpu/gg/fixes-binary-eltwise-dts-on-empty-input branch February 9, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@andrejsokolov andrejsokolov andrejsokolov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Milestone

2021.3

Development

Successfully merging this pull request may close these issues.

5 participants

@ggladilov @andrejsokolov @Maxim-Doronin @openvino-pushbot @ggladilo