Skip to content

[CPU] CumSum tensors with rank >= 6 support.#3859

Merged
dmitry-gorokhov merged 1 commit intoopenvinotoolkit:masterfrom
apertovs:ap/cum_sum_refactoring_and_extending
Feb 2, 2021
Merged

[CPU] CumSum tensors with rank >= 6 support.#3859
dmitry-gorokhov merged 1 commit intoopenvinotoolkit:masterfrom
apertovs:ap/cum_sum_refactoring_and_extending

Conversation

@apertovs
Copy link
Copy Markdown
Contributor

@apertovs apertovs commented Jan 14, 2021

issue: #41817

@apertovs apertovs added the category: CPU OpenVINO CPU plugin label Jan 14, 2021
@apertovs apertovs added this to the 2021.3 milestone Jan 14, 2021
@apertovs apertovs requested review from a team and dmitry-gorokhov January 14, 2021 13:56
@openvino-pushbot openvino-pushbot added the category: IE Tests OpenVINO Test: plugins and common label Jan 14, 2021
@dmitry-gorokhov
Copy link
Copy Markdown

dmitry-gorokhov commented Jan 14, 2021

@mandrono please review

@apertovs apertovs requested a review from mandrono January 14, 2021 14:09
mandrono
mandrono suggested changes Jan 15, 2021
View reviewed changes
@mandrono
Copy link
Copy Markdown

mandrono commented Jan 15, 2021

@apertovs
could you also add changes in config creation?
69 line: Precision inPrecision = i == 1 ? Precision::I32 : layer->insData[i].lock()->getTensorDesc().getPrecision();

@apertovs apertovs force-pushed the ap/cum_sum_refactoring_and_extending branch from 30c1541 to 3d79b72 Compare January 18, 2021 12:43
mandrono
mandrono approved these changes Jan 19, 2021
View reviewed changes
dmitry-gorokhov
dmitry-gorokhov reviewed Jan 26, 2021
View reviewed changes
@dmitry-gorokhov
Copy link
Copy Markdown

dmitry-gorokhov commented Jan 26, 2021

@apertovs Please rebase your branch on latest master as well

@apertovs apertovs force-pushed the ap/cum_sum_refactoring_and_extending branch from 3d79b72 to d3e6cd4 Compare January 27, 2021 11:22
@dmitry-gorokhov dmitry-gorokhov self-requested a review January 28, 2021 08:45
dmitry-gorokhov
dmitry-gorokhov approved these changes Jan 28, 2021
View reviewed changes
Copy link
Copy Markdown

@dmitry-gorokhov dmitry-gorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make CI green so I could merge the PR.

@apertovs apertovs force-pushed the ap/cum_sum_refactoring_and_extending branch from d3e6cd4 to 33d0f2a Compare February 1, 2021 10:41
@apertovs
[CPU] CumSum tensors with rank >= 6 support.
b7773d0 
[CPU] CumSum refactoring

Fix LayerConfig precision

Edit functions signature
@apertovs apertovs force-pushed the ap/cum_sum_refactoring_and_extending branch from 33d0f2a to b7773d0 Compare February 2, 2021 04:52
@dmitry-gorokhov dmitry-gorokhov merged commit d754e9b into openvinotoolkit:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

@mandrono mandrono mandrono approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels

category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Milestone

2021.3

Development

Successfully merging this pull request may close these issues.

4 participants

@apertovs @dmitry-gorokhov @mandrono @openvino-pushbot