[CPU][ARM] AclPoolingExecutor should not use default parameter values if provided ones are incorrect#35110
Merged
EgorDuplensky merged 3 commits intoopenvinotoolkit:masterfrom Apr 2, 2026
Conversation
| return {PoolingType::MAX, false}; | ||
| }(); | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
we can keep the previous version with unnamed lambda and just wrap return type with std::optional.
Then check:
if (!poolTypeOpt) {
return false;
}
pool_type = poolTypeOpt.value();
Also I recommend to get pool type first and then decide on 'exclude_padding'
| default: | ||
| DEBUG_LOG("Unknown rounding type: ", poolingAttrs.rounding); | ||
| return false; | ||
| } |
EgorDuplensky
approved these changes
Apr 1, 2026
Merged
via the queue into
openvinotoolkit:master
with commit Apr 2, 2026
35d22f2
219 of 221 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: