Skip to content

[core] Migrate frontends/ir/src/ to std::filesystem::path#34925

Merged
mlukasze merged 8 commits intoopenvinotoolkit:masterfrom
almilosz:almilosz/frontends-ir
Apr 2, 2026
Merged

[core] Migrate frontends/ir/src/ to std::filesystem::path#34925
mlukasze merged 8 commits intoopenvinotoolkit:masterfrom
almilosz:almilosz/frontends-ir

Conversation

@almilosz
Copy link
Copy Markdown
Contributor

@almilosz almilosz commented Mar 25, 2026

Details:

  • Changed the type of the weights_path parameter and member variable from std::string to std::filesystem::path in the InputModel and InputModelIRImpl classes
  • Updated the lambda function and return statement in FrontEnd::load_impl

Tickets:

AI Assistance:

  • AI assistance used: yes
  • codebase analysis

@github-actions github-actions bot added the category: IR FE OpenVINO IR v10 / v11 FrontEnd label Mar 25, 2026
@github-actions github-actions bot added category: inference OpenVINO Runtime library - Inference category: IE Tests OpenVINO Test: plugins and common category: GPU OpenVINO GPU plugin category: TEMPLATE OpenVINO Template plugin labels Mar 26, 2026
@almilosz almilosz marked this pull request as ready for review March 26, 2026 16:16
@almilosz almilosz requested review from a team as code owners March 26, 2026 16:16
@mlukasze mlukasze requested a review from Copilot March 27, 2026 05:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates IR frontend handling of weights paths from std::string to std::filesystem::path, and updates downstream consumers to convert back to std::string where required by existing runtime properties (e.g., ov::weights_path).

Changes:

  • Switch IR FE InputModel / InputModelIRImpl weights_path from std::string to std::filesystem::path and propagate it via model rt_info ("__weights_path").
  • Update IR FE FrontEnd::load_impl to pass std::filesystem::path through to InputModel.
  • Update several call sites (Core, GPU plugin, Template plugin, and a functional test) to treat "__weights_path" as a std::filesystem::path and convert to std::string for ov::weights_path.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/tests/functional/base_func_tests/include/behavior/compiled_model/compiled_model_base.hpp Fix SPDX tag typo and store __weights_path as std::filesystem::path in rt_info for the test.
src/plugins/template/src/plugin.cpp Convert model rt_info __weights_path (now path) into ov::weights_path string property.
src/plugins/intel_gpu/src/runtime/execution_config.cpp Convert model rt_info __weights_path (now path) into ov::weights_path string property for GPU execution config.
src/inference/src/dev/core_impl.cpp Convert model rt_info __weights_path (now path) into ov::weights_path string when computing weightless cache behavior.
src/frontends/ir/src/input_model.hpp Change weights_path constructor parameter type to std::filesystem::path and include <filesystem>.
src/frontends/ir/src/input_model.cpp Store m_weights_path as std::filesystem::path and write it into model rt_info as __weights_path.
src/frontends/ir/src/frontend.cpp Pass std::filesystem::path through create_input_model and return create_input_model(weights_path) directly.

@praasz praasz added this to the 2026.2 milestone Mar 27, 2026
This reverts commit fac718e.
This reverts commit f92a297.
@github-actions github-actions bot removed category: inference OpenVINO Runtime library - Inference category: IE Tests OpenVINO Test: plugins and common labels Mar 31, 2026
@github-actions github-actions bot removed category: GPU OpenVINO GPU plugin category: TEMPLATE OpenVINO Template plugin labels Mar 31, 2026
@almilosz almilosz requested review from Copilot and praasz March 31, 2026 11:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

@almilosz almilosz added this pull request to the merge queue Apr 1, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 1, 2026
@almilosz almilosz requested a review from barnasm1 April 1, 2026 08:55
@mlukasze mlukasze added this pull request to the merge queue Apr 2, 2026
Merged via the queue into openvinotoolkit:master with commit c9178de Apr 2, 2026
226 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: IR FE OpenVINO IR v10 / v11 FrontEnd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants