Skip to content

[IE][CMAKE] Add some libraries to ie_developer export list#2279

Merged
ilya-lavrenov merged 1 commit intoopenvinotoolkit:masterfrom
vinograd47:vv/export-static-libs
Sep 17, 2020
Merged

[IE][CMAKE] Add some libraries to ie_developer export list#2279
ilya-lavrenov merged 1 commit intoopenvinotoolkit:masterfrom
vinograd47:vv/export-static-libs

Conversation

@vinograd47
Copy link
Copy Markdown
Contributor

The following libraries:

  • vpu_common_lib_test_static
  • ieTestHelpers_s

Those libraries might be helpful for standalone plugins tests.

@ilyachur
Copy link
Copy Markdown
Contributor

The following libraries:

  • vpu_common_lib_test_static
  • ieTestHelpers_s

Those libraries might be helpful for standalone plugins tests.

Why do we need to have those libraries for other plugins?

@vinograd47
Copy link
Copy Markdown
Contributor Author

They might be used by other plugin's unit tests (if they links with static version of IE library). As for vpu_common_lib - it contains some utility stuff, which is already used by some standalone plugins.

list(APPEND EXPORT_DEPENDENCIES
funcTestUtils
ieTestHelpers
ieTestHelpers_s
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it looks strange that the same binary is linked against both static and non-static versions?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've thoght that this variable was used for ie_developer_export_targets only. Fixed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, ieTestHelpers_s is a part of deprecated tests infra, why do you need to use it?
CC @iefode what do you think?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as ieTestHelpers. I don't see reasons to export only one of them.

The following libraries:

* `vpu_common_lib_test_static`
* `ieTestHelpers_s`

Those libraries might be helpful for standalone plugins tests.
@ilya-lavrenov ilya-lavrenov merged commit 60ad6ed into openvinotoolkit:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: build OpenVINO cmake script / infra category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants