[IE][VPU] Klockwork ShaveElfMetadataParser.cpp#2230
Closed
maxim-kurin wants to merge 1 commit intoopenvinotoolkit:releases/2021/1from
Closed
[IE][VPU] Klockwork ShaveElfMetadataParser.cpp#2230maxim-kurin wants to merge 1 commit intoopenvinotoolkit:releases/2021/1from
maxim-kurin wants to merge 1 commit intoopenvinotoolkit:releases/2021/1from
Conversation
This was referenced Sep 14, 2020
ghost
approved these changes
Sep 15, 2020
ggladilov
reviewed
Sep 15, 2020
| case md_type_op_xor: | ||
| case md_type_op_shl: | ||
| case md_type_op_lshr: | ||
| assert(values.size() >= 2); |
Contributor
There was a problem hiding this comment.
Don't use simple assert - it isn't evaluated outside of Debug mode - use dedicated macros like VPU_THROW_UNLESS with descriptive messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file is used both on MDK and OpenVINO side. Klockwork for MDK found a problem in this file. This is the fix for that problem.