Skip to content

[Snippets] Fixed insertion position iterators#18023

Merged
maxnick merged 5 commits intoopenvinotoolkit:masterfrom
a-sidorova:fix/snippets/buffer_insertion
Jul 5, 2023
Merged

[Snippets] Fixed insertion position iterators#18023
maxnick merged 5 commits intoopenvinotoolkit:masterfrom
a-sidorova:fix/snippets/buffer_insertion

Conversation

@a-sidorova
Copy link
Copy Markdown
Contributor

@a-sidorova a-sidorova commented Jun 13, 2023

Details:

  • Fixed Buffer insertion position: potential_consumers is unsorted by linear IR set. We have to find first expr in Linear IR from the set to insert Buffer before all consumers
  • Added OPENVINO_ASSERT for all std::find if needed

Tickets:

  • N/A

@a-sidorova a-sidorova requested a review from a team as a code owner June 13, 2023 06:35
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Jun 13, 2023
@a-sidorova a-sidorova added this to the 2023.1 milestone Jun 13, 2023
IvanNovoselov
IvanNovoselov reviewed Jun 19, 2023
View reviewed changes
@a-sidorova a-sidorova force-pushed the fix/snippets/buffer_insertion branch from 9c85600 to aff451a Compare June 21, 2023 07:30
@a-sidorova a-sidorova requested a review from IvanNovoselov June 21, 2023 07:34
@a-sidorova a-sidorova force-pushed the fix/snippets/buffer_insertion branch 2 times, most recently from ca05b08 to fa65874 Compare June 22, 2023 07:19
@a-sidorova a-sidorova force-pushed the fix/snippets/buffer_insertion branch from fa65874 to 4e960a3 Compare July 3, 2023 13:58
@a-sidorova
Copy link
Copy Markdown
Contributor Author

a-sidorova commented Jul 3, 2023

@IvanNovoselov could you take a look one more time please? Thank you!

@a-sidorova a-sidorova force-pushed the fix/snippets/buffer_insertion branch from 05339e8 to 32cd75c Compare July 5, 2023 12:21
@maxnick maxnick merged commit 2532fdb into openvinotoolkit:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@IvanNovoselov IvanNovoselov IvanNovoselov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@IvanNovoselov IvanNovoselov

Labels

category: CPU OpenVINO CPU plugin

Projects

None yet

Milestone

2023.1

Development

Successfully merging this pull request may close these issues.

3 participants

@a-sidorova @IvanNovoselov @maxnick