Skip to content

DOCS Change optimization images#17421

Closed
tsavina wants to merge 3 commits intoopenvinotoolkit:masterfrom
tsavina:image_update
Closed

DOCS Change optimization images#17421
tsavina wants to merge 3 commits intoopenvinotoolkit:masterfrom
tsavina:image_update

Conversation

@tsavina
Copy link
Copy Markdown
Contributor

@tsavina tsavina commented May 8, 2023

Details:

  • item1
  • ...

Tickets:

  • ticket-id

@tsavina tsavina requested a review from a team as a code owner May 8, 2023 15:18
@tsavina tsavina requested review from zKulesza and removed request for a team May 8, 2023 15:18
@github-actions github-actions bot added the category: docs OpenVINO documentation label May 8, 2023
@MaximProshin MaximProshin requested a review from AlexKoff88 May 9, 2023 05:39
@MaximProshin
Copy link
Copy Markdown
Contributor

@AlexKoff88 , please check updates in the diagrams

@MaximProshin MaximProshin self-requested a review May 11, 2023 05:53
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find where this diagram is used. Is this a POT-specific picture? The reason why I am asking is that if it is a common picture that POT should be replaced with NNCF.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. sorry I might have accidentally closed the comment with explanation
it fixes POT description page https://docs.openvino.ai/latest/pot_introduction.html

@yury-gorbachev
Copy link
Copy Markdown
Contributor

Within this document (tmo_introduction.html) there is diagram that has model optimizer. We probably want to change it to convert modes or something similar. Not sure if this is covered by separate PR. cc: @slyalin

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IR is just a serialized representation for OpenVINO model. As we are becoming more Pythonic, and moving away from CLI tool, here is a better option for names:

  • Convert to OpenVINO IR -> Convert to OpenVINO Model
  • Full precision IR -> Full precision OpenVINO Model
  • Optimized IR -> Optimized OpenVINO Model

And, probably in this particular diagram, to emphasize separation between Development and Deployment the latest step in Development should be serialization of Optimized OpenVINO Model to Optimized OpenVINO IR. Some additional tuning for names is still required.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image says you need to convert your model to IR before you "optimize with NNCF" (in the PTQ part). This is not true for PTQ with NNCF (it was for POT).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change Run Model Optimizer to Convert to OpenVINO IR in one of the pictures, then apply similar changes to this one.

@slyalin
Copy link
Copy Markdown
Contributor

slyalin commented May 12, 2023

Within this document (tmo_introduction.html) there is diagram that has model optimizer. We probably want to change it to convert modes or something similar. Not sure if this is covered by separate PR. cc: @slyalin

Don't know about another PR. Adding @kblaszczak-intel and @andrei-kochin. The changes haven't been prepared yet. In other comments in this PR, I recommended updating pictures immediately as it has been already partially done.

@tsavina tsavina requested a review from kblaszczak-intel May 15, 2023 11:46
@akladiev
Copy link
Copy Markdown
Collaborator

This PR will be closed in a week because of 2 weeks of no activity.

@akladiev akladiev added the Stale label May 30, 2023
@tsavina tsavina closed this May 31, 2023
@tsavina tsavina deleted the image_update branch December 5, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: docs OpenVINO documentation Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants