[ARM CPU] Fix eltwise op tests (Divide)#17029
Merged
ilya-lavrenov merged 14 commits intoopenvinotoolkit:masterfrom Apr 19, 2023
Merged
[ARM CPU] Fix eltwise op tests (Divide)#17029ilya-lavrenov merged 14 commits intoopenvinotoolkit:masterfrom
ilya-lavrenov merged 14 commits intoopenvinotoolkit:masterfrom
Conversation
…into an/fix_tetsts
…into an/fix_tetsts
…into an/fix_tetsts
ilya-lavrenov
approved these changes
Apr 18, 2023
| if (!divide) { | ||
| return false; | ||
| } | ||
| if (divide->get_element_type() != ov::element::i32) { |
There was a problem hiding this comment.
I would propose to use divide->get_element_type().is_integral_number() instead. We are going to merge I64 native support, so it would be nice to make this transofmration suitable for upcoming change.
| namespace ov { | ||
| namespace intel_cpu { | ||
|
|
||
| ConvertI32Div::ConvertI32Div() { |
There was a problem hiding this comment.
Maybe: DecomposeIntegerDivide?
File name should also be changed
| CPU_REGISTER_PASS_ARM(manager, ConvertConv1D); | ||
| CPU_REGISTER_PASS_ARM(manager, ConvertGroupConv1D); | ||
| CPU_REGISTER_PASS_ARM(manager, ConvertGroupConvolution); | ||
| CPU_REGISTER_PASS_ARM(manager, ConvertI32Div); |
There was a problem hiding this comment.
Lets put the explanation here: The plugin computes Divide in floating point precision. To preserve correct math for integer division we need to insert explicit Floor operation.
…to an/fix_tetsts
…into an/fix_tetsts
Contributor
Author
|
@dmitry-gorokhov done |
dmitry-gorokhov
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.