Skip to content

Sns explicit tiles#13330

Closed
IvanNovoselov wants to merge 4 commits intoopenvinotoolkit:masterfrom
IvanNovoselov:sns_explicit_tiles
Closed

Sns explicit tiles#13330
IvanNovoselov wants to merge 4 commits intoopenvinotoolkit:masterfrom
IvanNovoselov:sns_explicit_tiles

Conversation

@IvanNovoselov
Copy link
Copy Markdown
Contributor

@IvanNovoselov IvanNovoselov commented Oct 4, 2022 •
edited
Loading

Details:

  • Implement explicit planar tiles representation
  • Reformulate all presently implemented tile-related optimizations using this new representation

Tickets:

  • 92362

Yet to do:

  • Remove dynamism-related emitters
  • Refactor assign_registers to handle gp regs
  • Rename tile -> loop
  • Remove commented debug prints
  • Perform dlb validation

@IvanNovoselov IvanNovoselov self-assigned this Oct 4, 2022
@IvanNovoselov IvanNovoselov requested review from a team as code owners October 4, 2022 17:23
@dmitry-gorokhov dmitry-gorokhov added this to the 2022.3 milestone Oct 5, 2022
@IvanNovoselov IvanNovoselov force-pushed the sns_explicit_tiles branch 5 times, most recently from 2567c13 to 109872e Compare October 12, 2022 14:16
@IvanNovoselov IvanNovoselov force-pushed the sns_explicit_tiles branch 3 times, most recently from 9b6b8fc to 3b2137b Compare October 19, 2022 11:30
@IvanNovoselov
Copy link
Copy Markdown
Contributor Author

IvanNovoselov commented Oct 25, 2022

DLB validation is finished and revealed no issues. The results are in the ticket.

a-sidorova
a-sidorova reviewed Oct 25, 2022
View reviewed changes
Comment thread src/common/snippets/include/snippets/op/loop.hpp
a-sidorova
a-sidorova reviewed Nov 4, 2022
View reviewed changes
Comment thread src/common/snippets/include/snippets/op/loop_helpers.hpp
Comment thread src/common/snippets/src/pass/insert_loops.cpp Outdated
Comment thread src/common/snippets/tests/src/pass/canonicalization.cpp Outdated
Comment thread src/plugins/intel_cpu/src/emitters/jit_snippets_emitters.cpp Outdated
Comment thread src/plugins/intel_cpu/src/nodes/subgraph.cpp Outdated
Comment thread src/plugins/intel_cpu/src/nodes/subgraph.cpp Outdated
Comment thread src/plugins/intel_cpu/tests/functional/shared_tests_instances/snippets/add.cpp
Comment thread src/tests/functional/plugin/shared/include/snippets/add.hpp Outdated
@IvanNovoselov IvanNovoselov force-pushed the sns_explicit_tiles branch 2 times, most recently from 540b4a2 to a411051 Compare November 7, 2022 10:24
@IvanNovoselov IvanNovoselov force-pushed the sns_explicit_tiles branch 2 times, most recently from 704804d to 3cecb89 Compare November 10, 2022 16:03
@dmitry-gorokhov dmitry-gorokhov removed this from the 2022.3 milestone Nov 16, 2022
@IvanNovoselov IvanNovoselov mentioned this pull request Nov 23, 2022
Merged
@IvanNovoselov
Copy link
Copy Markdown
Contributor Author

IvanNovoselov commented Nov 30, 2022

This PR will be merged as a part of a larger one PR#14327

@IvanNovoselov
Copy link
Copy Markdown
Contributor Author

IvanNovoselov commented Dec 23, 2022

Closing, since this code was merged on a separate branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitry-gorokhov dmitry-gorokhov Awaiting requested review from dmitry-gorokhov

1 more reviewer

@a-sidorova a-sidorova a-sidorova approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels

category: CPU OpenVINO CPU plugin do not merge do_not_merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IvanNovoselov @a-sidorova @dmitry-gorokhov