Split list_topologies.yml into per-model config files#276
Split list_topologies.yml into per-model config files#276IRDonch merged 3 commits intoopenvinotoolkit:developfrom IRDonch:split
Conversation
|
Draft because it depends on #267 (well, it doesn't really, but it would make little sense to merge it before that one). |
|
I'd say, so far - so good. One minor item is that proxy doesn't make it easier to download the models. Things, like On another note (we've discussed it briefly with @vladimir-dudnik ) - certain sets of models belong to the same "family" and, maybe, it makes sense to have another level for those. For example, densenet-121/161/169/201. There could be a folder densenet and the respective models inside it. If we talk about intel models, there's action-recognition-0001-decoder/-encoder and others. Not that I think it's mandatory (even the current state is much better than what we had before) but it somewhat makes things more tidy and the models of the same "family" can share the common documentation. |
This seems to have nothing to do with this PR, though? And the downloader does support proxies through the standard |
Correct, just something I stumbled upon when I was trying it out. What do you think about "family folders" ? Worthwhile or not? If yes, this time or later? |
It's worth considering; however, it's definitely a task for later, as it would drastically expand the scope of required changes. |
|
Got it, thanks! |
|
@yssemaev any update on the question? |
|
"Copyright (c) 2019 Intel Corporation" header should be in all human readable files |
|
@yssemaev Do you mean just the copyright line, or the full banner ("Licensed under the Apache License", etc.)? |
Moving to per-model configs will make it easier to maintain the model configuration and reduce the amount of information that needs to be included in the config (since name and subdirectory are now inferred). This change is transparent to users who don't read list_topologies.yml directly. For compatibility the -c option is still supported and will let users use a config in the old format. However, it is deprecated and will be removed in a future release. I didn't provide a way to specify an alternate tree of model configs in the new format, because such a feature doesn't seem useful to me (and the config format is still not supposed to be stable).
…rinting This has two beneficial effects: * the output of --print_all is now grouped by category (intel/public); * the models are now downloaded/converted in the same order they're printed by --print_all.
Moving to per-model configs will make it easier to maintain the model configuration and reduce the amount of information that needs to be included in the config (since name and subdirectory are now inferred).
This change is transparent to users who don't read list_topologies.yml directly.
For compatibility the -c option is still supported and will let users use a config in the old format. However, it is deprecated and will be removed in a future release. I didn't provide a way to specify an alternate tree of model configs in the new format, because such a feature doesn't seem useful to me (and the config format is still not supposed to be stable).