Model Converter: try to run Model Optimizer as a package#2395
Merged
IRDonch merged 1 commit intoopenvinotoolkit:developfrom May 17, 2021
IRDonch:use-mo-as-package
Merged
Model Converter: try to run Model Optimizer as a package#2395IRDonch merged 1 commit intoopenvinotoolkit:developfrom IRDonch:use-mo-as-package
IRDonch merged 1 commit intoopenvinotoolkit:developfrom
IRDonch:use-mo-as-package
Conversation
If our tools are installed as part of the `openvino-dev` distribution, then it doesn't make sense to ask the user to run `setupvars`, seeing as: 1. It doesn't exist. 2. We know that MO is installed as part of the same distribution. Therefore, before trying to find MO the old way, try to locate its package and if that succeeds, run it as a package. I moved the documentation for the `-p` option up, because I'm referencing its value in the documentation for the `--mo` option. `get_package_path` is in `_common`, because we're likely going to implement the same thing in the quantizer (for POT).
Author
SDxKeeper
approved these changes
May 15, 2021
jkamelin
approved these changes
May 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If our tools are installed as part of the
openvino-devdistribution, then it doesn't make sense to ask the user to runsetupvars, seeing as:Therefore, before trying to find MO the old way, try to locate its package and if that succeeds, run it as a package.
I moved the documentation for the
-poption up, because I'm referencing its value in the documentation for the--mooption.get_package_pathis in_common, because we're likely going to implement the same thing in the quantizer (for POT).