Touchup#4
Closed
trevp wants to merge 15 commits intoopenssl:masterfrom
Closed
Conversation
added 15 commits
June 13, 2013 22:36
Contributor
|
Merged. |
Closed
2 tasks
This was referenced Dec 22, 2023
2 tasks
This was referenced Mar 18, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds docs for s_client, s_server, and SSL_CTX_use_serverinfo.
Added "-1" callback return value to skip sending the extension.
Fixed bug where serverinfo ClientHello extensions were allowed to be nonempty.
Fixed bug where serverinfo callback would return empty extension (instead of skipping the extension) in the case where serverinfo data isn't present for the selected certificate type, but the ClientHello triggers the extension callback.
Changed NULL second server callback to skip extension, instead of sending empty extension data. (Note that a NULL first client callback sends an empty extension. So this may seem a little inconsistent, but I think it's the most useful defaults - e.g. if a NULL first client callback omitted the extension it would be useless.)
Added tests.
Renames serverinfo_validate() -> serverinfo_process_buffers() since this function registers callbacks as well as validates.
Changed serverinfo callback to handle errors from serverinfo_find_extension(), instead of ignoring them.