Added SSL_CTX_get0_alpn_protos() and SSL_get0_alpn_protos() #29646
+115
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e45ddba to
52baa56
Compare
b56b8b9 to
638ed0e
Compare
paulidale
reviewed
Jan 15, 2026
9065fc7 to
523992a
Compare
paulidale
previously approved these changes
Jan 16, 2026
mattcaswell
requested changes
Jan 16, 2026
| SSL_CTX_get_alpn_protos() and SSL_get_alpn_protos() are used by the client to | ||
| get the list of protocols available to be negotiated. Returns a pointer to | ||
| protocol list in B<protos> with length B<protos_len>. It is not NUL-terminated. | ||
| B<protos> must not be freed. |
Member
There was a problem hiding this comment.
Some reference to the format of the data would be helpful here (like we do in the paragraph above). E.g. "The returned list is in protocol-list format as described below". Or some similar wording.
Fixes openssl#4952 Co-authored-by: Pauli <ppzgs1@gmail.com>
ffcd819 to
8e42942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added useful SSL_CTX_get0_alpn_protos() and SSL_get0_alpn_protos().
Normally I would use size_t for length, but here I prioritize the consistency. I think I only violated that by checking for NULL parameters, which is proper for public functions. Maybe in the next small PR I'll add similar checks to the surrounding functions.
Fixes #4952