Add an Apple privacy info file for OpenSSL.#24032
Add an Apple privacy info file for OpenSSL.#24032slontis wants to merge 1 commit intoopenssl:masterfrom
Conversation
a2a5c48 to
629ddce
Compare
|
Fixes #23494 |
|
Should we treat it as a bug fix and add it on all branches? |
|
Or documentation actually. |
|
As @fwh-dc is the community maintainer of iOS platforms I kindly ask him to review this. |
|
LGTM. I have one minor thing to consider: |
|
There is also a discussion about this at #23262 |
paulidale
left a comment
There was a problem hiding this comment.
I'm fine back merging this anywhere.
|
someone with better knowledge of the config/perl would need to add it to the install process.. At least this gives a reference file. |
|
@fwh-dc Which directory it should be installed to? The same where the libcrypto/libssl .dylib is installed to? BTW the iOS targets by default disable The iOS targets really need some fine-tuning/cleanups IMO to be more comprehensive and useful. |
Good question. I think it's fine to just have the file for reference as suggested. We can always improve from there. |
|
Doesn't this need to be added to the appropriate directory in the podspec and packaging (resource bundle) ? |
|
Based on #23494 (comment), I take it this was derived from the BoringSSL one? Keep in mind that We have an empty one, but we'd also removed our remaining |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
|
I do not see a need for us to install this. It's useful documentation for folks building for Apple products. |
Yeah maybe we need to declare C617.1 Although we never use the timestamp info obtained with stat. |
|
OTC: We are OK with adding the file. The contents need to be right. It seems we need to declare C617. |
|
C617 is probably not right, and we might need to ask apple for a new id.
|
Any reason why C617 is not right? |
|
I guess I was confused, it looks right
|
|
Apple's description is unclear to me, but it seems like the best match given the documentation. For instance, how do we check certificates on iOS, and do those files belong to the app as the documentation seems to imply? It's also not clear if that code means it can be transferred off the device or not, which we don't do.
|
| <plist version="1.0"> | ||
| <!-- | ||
| This is an Apple related Privacy Manifest File for OpenSSL as required by | ||
| https://developer.apple.com/support/third-party-SDK-requirements/ |
There was a problem hiding this comment.
(minor) should there be a space at the beginning of this line?
|
Is there someone who actually has Xcode installed who can generate this file (Submit a new PR if you want) |
|
In light of #24260 can this be closed now? |
|
I would think so. |
Checklist