Fix regression in ASN1_UTCTIME_cmp_time_t#218
Closed
zenazn wants to merge 1 commit intoopenssl:masterfrom
Closed
Conversation
Previously, ASN1_UTCTIME_cmp_time_t would return 1 if s > t, -1 if s < t, and 0 if s == t. This behavior was broken in a refactor [0], resulting in the opposite time comparison behavior. [0]: 904348a
|
I can confirm the bug and the fix. We found the same problem in pyOpenSSL after switching from 1.0.1l to 1.0.2. The behavior is exactly reversed in 1.0.2 causing certificates to be detected as expired when in fact they are not and vice-versa. |
Contributor
Author
|
This is being tracked as issue 3706 on the openssl RT. http://www.mail-archive.com/openssl-dev@openssl.org/msg38201.html |
Contributor
Author
|
This got fixed in da27006 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, ASN1_UTCTIME_cmp_time_t would return 1 if s > t, -1 if
s < t, and 0 if s == t.
This behavior was broken in a refactor (904348a), resulting in the opposite
time comparison behavior.