Skip to content

Conversation

@juhaszviktor
Copy link

If the $cc is "gcc-x.y" or "ccache gcc" the make depend want to use
the makedepend program, but it is not on the machine.
In this case the $cc also should be used as MAKEDEPPROG

Signed-off-by: Viktor Juhasz viktor.juhasz@balabit.com

If the $cc is "gcc-x.y" or "ccache gcc" the make depend want to use
the makedepend program, but it is not on the machine.
In this case the $cc also should be used as MAKEDEPPROG

Signed-off-by: Viktor Juhasz <viktor.juhasz@balabit.com>
@richsalz richsalz added this to the 1.0.2 milestone Sep 1, 2016
@richsalz richsalz self-assigned this Sep 1, 2016
@richsalz
Copy link
Contributor

richsalz commented Sep 1, 2016

+1

@dot-asm
Copy link
Contributor

dot-asm commented Sep 10, 2016

In master we actually examine output from $cc --version. This is much more reliable way to detect compiler than just looking at command line. For example there are systems where gcc (or clang) "hide" behind cc...

@richsalz richsalz removed the reviewed label Sep 10, 2016
@richsalz
Copy link
Contributor

good point. i remove my +1 :)

@levitte
Copy link
Member

levitte commented Nov 15, 2016

@juhaszviktor, do you have a response re @dot-asm's comment?

@sjackman
Copy link

In master we actually examine output from $cc --version.

@dot-asm Has this feature made it into a stable release?

@levitte
Copy link
Member

levitte commented Jul 6, 2017

@dot-asm Has this feature made it into a stable release?

Yup, even in 1.0.2. Does that mean we simply close this?

@glensc
Copy link

glensc commented Nov 18, 2017

@levitte: please prove your claims. with git commit link or something.

the patch from here still applies to "1.0.2", so i don't think it was applied upstream

######################################################################## 100,0%
==> Downloading https://github.com/openssl/openssl/pull/1524.patch
==> Downloading from https://patch-diff.githubusercontent.com/raw/openssl/openssl/pull/1524.patch
######################################################################## 100,0%
==> Patching
==> Applying 1524.patch
patching file Configure
Hunk #1 succeeded at 1723 (offset 2 lines).
==> perl ./Configure --prefix=/home/linuxbrew/.linuxbrew/Homebrew/Cellar/openssl/1.0.2m --openssldir=/home/linuxbrew/.linuxbrew
==> make depend

@levitte
Copy link
Member

levitte commented Nov 18, 2017

@glensc, I was wrong. Must have looked at the wrong checkout. Thanks for catching it

@levitte
Copy link
Member

levitte commented Nov 18, 2017

Also, I just had a look at the $cc --version checking mechanism, and I think there are flaws in there...

@levitte
Copy link
Member

levitte commented Nov 18, 2017

#4755 is an alternative fix of the same thing, but with a basis on $ecc consistency. Please have a look and decide what you think is best.

@mspncp
Copy link
Contributor

mspncp commented Dec 10, 2017

Since #4755 was merged and closed, this can be closed, too?

@levitte
Copy link
Member

levitte commented Dec 11, 2017

I believe it should, yes. @juhaszviktor, do you agree?

@mattcaswell
Copy link
Member

No response to the above questions about closure. Assuming this is fixed by #4755. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants