Fix typos, repeated words, align spelling to LDP #12527
Conversation
paulidale
left a comment
There was a problem hiding this comment.
A marathon effort. A couple of mistakes and some suggestions.
crypto/ts/ts_err.c
Outdated
There was a problem hiding this comment.
The various TIME_STAMP macros should be updated in due course. It doesn't have to be in this PR.
There was a problem hiding this comment.
Since i had to redo several steps to get a merge-free PR on the updated master, i've addressed as well the TIME_STAMP macros in the latest commit.
include/internal/ktls.h
Outdated
There was a problem hiding this comment.
This is wrong: sendfile system call or even sendfile(2) system call.
levitte
left a comment
There was a problem hiding this comment.
Hmmm, US vs UK english stuff? (I've only marked a few)
apps/cmp.c
Outdated
There was a problem hiding this comment.
These changes are applying the recommended rules of the Linux Documentation Project https://man7.org/linux/man-pages/man7/man-pages.7.html
These changes are as well included in openssl/util/find-doc-nits
apps/cms.c
Outdated
apps/openssl.c
Outdated
apps/s_client.c
Outdated
apps/s_server.c
Outdated
apps/s_server.c
Outdated
apps/ts.c
Outdated
crypto/asn1/a_int.c
Outdated
crypto/asn1/a_int.c
Outdated
There was a problem hiding this comment.
Zeros is plural and zeroes is a verb.
|
To address the comment "US vs UK english stuff?" directly: |
|
Hmm, i've resolved the conflicts of this pull requests by merging with master (The conflicts were introduced by the master branch evolving). But now, all the changes that happened in the meantime are showing up as changes in my last commit. i should probably undo my merge. |
|
Please do not do merge commits as they are not allowed. Could you please git rebase instead? |
|
ok. i'll undo make an rebase attempt. |
44b87cc to
18cfbd0
Compare
|
There are still 2 merge commits. |
|
These merges were the result of the resolving the conflicts (on a "git pull upstream"). So, i have probably reset everything to my starting point from master, update then master (should be free of conflicts) and trying the reapply my changes afterwards. Probably, one gets as well merges, when doing a "Resolve conflicts" via the GitHub interface. |
|
Yes, unfortunately resolving conflicts via the GitHub interface cannot be done. |
6c5cc58 to
c78d3d9
Compare
|
What I have done: since later commits on master on files that were changed in this PR lead to merges (which are not wanted), i undid all my changes, rebased the branch on master and applied the changes again. Therefore, this PR is merge-free. |
|
Could you please rebase if you're still interested? |
|
i will try to revamp it, but i will take me a few days... |
655a104 to
9413e5e
Compare
9413e5e to
1acb2e6
Compare
|
It seems that the "push force" i used to get this voluminous PR in sync again closed the PR. The new one is in #16712 |
This is a follow-up commit to #12320 and #12460 and concerns all the .c- and .h-files of the project. The discussion in #12320 showed interest in source code changes, which are provided by this pull request. The changes are relative to the master branch of GitHub from Thu Jul 23 17:40:40 2020.
Checklist