Conversation
After make distclean the following directories are still around: crypto/include crypto/providers doc/man doc/html This patch cleans those up or avoids to create them in the first place. [extended tests]
First the line "del /Q /F $(GENERATED)" was too long then it happens that nmake dies not invoke the builtin rmdir if a cygwin/bin is in the path. Avoid both by using perl for removing files and dirs. [extended tests]
|
I would suggest to cherry-pick the second commit "Remove pod2htmd.tmp in make clean" I have not observed the overlong line in windows make clean, for 1.1.1, |
|
Richard, you probably remember the issue with the "echo |
vdukhovni
left a comment
There was a problem hiding this comment.
Looks OK to me, but this requires testing on platforms I don't have access to, so I don't feel I can give the final thumbs up.
|
I did test that on a windows 7 machine. |
Maybe you just trust me then? |
I do, but if Richard is free to take a look, he's much more familiar with the build-system than I. I am not sure I be doing approvals after only cursory inspection. Though perhaps with the build-system I may not need to be quite so cautious. Ping me again in a couple of days if nobody else steps forward... |
You know it quite well, reviewing is not a matter of trust or distrust. It‘s simply better if someone else checks the changes independently. As the proverb says: „Vertrauen ist gut, Kontrolle ist besser.“ Maybe I find some time to test it... |
|
Just for reference, when I post a GCC patch, bootstrap takes hours, and the test suite a day or more. |
|
Removing windows stuff for now. So since I started this PR new bugs were introduced, |
This makes distclean work correctly in master.
The windows issue is complicated by two effects,
which may be due to the specific windows machine.
First it has one of the commands to delete all generated targets
exceed the command line limit of windows.
And this machine has a cygwin somewhere in the path
almost at the end but its /usr/bin/rmdir nevetheless
overrides the builtin rmdir which makes the rmdir fail,
because it does not recognize "/S" and "/Q".