-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Closed
Description
s->session->ext.alpn_selected =
OPENSSL_memdup(s->s3->alpn_selected, s->s3->alpn_selected_len);
if (s->session->ext.alpn_selected == NULL) {
SSLfatal(s, SSL_AD_INTERNAL_ERROR,
SSL_F_TLS_CONSTRUCT_NEW_SESSION_TICKET,
ERR_R_MALLOC_FAILURE);
return 0;
}
s->session->ext.alpn_selected_len = s->s3->alpn_selected_len;This code is used in 2 different files, but OPENSSL_free(s->session->ext.alpn_selected) is missed in the second one
https://github.com/openssl/openssl/blob/master/ssl/statem/statem_srvr.c#L4110
https://github.com/openssl/openssl/blob/master/ssl/statem/extensions_clnt.c#L1666
I can provide a pull request if free is missed.
Thanks!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels