Skip to content

Missing OPENSSL_free #7651

@ManSoSec

Description

@ManSoSec
            s->session->ext.alpn_selected =
                OPENSSL_memdup(s->s3->alpn_selected, s->s3->alpn_selected_len);
            if (s->session->ext.alpn_selected == NULL) {
                SSLfatal(s, SSL_AD_INTERNAL_ERROR,
                         SSL_F_TLS_CONSTRUCT_NEW_SESSION_TICKET,
                         ERR_R_MALLOC_FAILURE);
                return 0;
            }
            s->session->ext.alpn_selected_len = s->s3->alpn_selected_len;

This code is used in 2 different files, but OPENSSL_free(s->session->ext.alpn_selected) is missed in the second one

https://github.com/openssl/openssl/blob/master/ssl/statem/statem_srvr.c#L4110
https://github.com/openssl/openssl/blob/master/ssl/statem/extensions_clnt.c#L1666

I can provide a pull request if free is missed.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions