Don't expose ViMbAdmin's patch level in the footer#299
Merged
barryo merged 3 commits intoopensolutions:masterfrom Feb 23, 2023
Merged
Don't expose ViMbAdmin's patch level in the footer#299barryo merged 3 commits intoopensolutions:masterfrom
barryo merged 3 commits intoopensolutions:masterfrom
Conversation
Exposing the exact patch level allows attackers to easily identify likely vulnerable instances of ViMbAdmin if a security flaw happens to be found. This commit simply replaces the exact version string ('3.3.0') with the milestone version string ('3.3') in ViMbAdmin's footer.
If Google Groups or any other kind of forum is revived, one should probably rather add the links to ViMbAdmin's website and the GitHub repo instead, not include it in the footer of every single ViMbAdmin instance.
Member
|
Merged with minor change - keeping full version for admins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposing the exact patch level allows attackers to easily identify likely vulnerable instances of ViMbAdmin if a security flaw happens to be found. This commit simply replaces the exact version string ('3.3.0') with the milestone version string ('3.3') in ViMbAdmin's footer. See 013cfec
Additional changes: