Add activation dynamics smoothing property to DeGrooteFregly2016Muscle#4007
Merged
nickbianco merged 10 commits intomainfrom Feb 7, 2025
Merged
Add activation dynamics smoothing property to DeGrooteFregly2016Muscle#4007nickbianco merged 10 commits intomainfrom
DeGrooteFregly2016Muscle#4007nickbianco merged 10 commits intomainfrom
Conversation
carmichaelong
approved these changes
Feb 5, 2025
Member
carmichaelong
left a comment
There was a problem hiding this comment.
LGTM.
Outside of the scope of this PR: Noting that mutMuscle variable might be unnecessary in some places and could just use muscle instead
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nickbianco)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #3990
Brief summary of changes
Adds property to
DeGrooteFregly2016Muscleto control the smoothing applied to the switch between muscle activation and deactivation. The default value of the property is set to the original model value, but the model will issue a warning to recommend increasing the value to 10.0 based on @tvdbogert's suggestion.Testing I've completed
Add a subtest to
DeGrooteFregly2016MuscleLooking for feedback on...
CHANGELOG.md (choose one)
This change is