Allow paths fit by PolynomialPathFitter to depend on more than 6 coordinates#4001
Merged
nickbianco merged 2 commits intomainfrom Jan 31, 2025
Merged
Allow paths fit by PolynomialPathFitter to depend on more than 6 coordinates#4001nickbianco merged 2 commits intomainfrom
PolynomialPathFitter to depend on more than 6 coordinates#4001nickbianco merged 2 commits intomainfrom
Conversation
…6 or less coordinates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #3995
Brief summary of changes
Removes a restriction in
PolynomialPathFitterpreventing paths with more than 6 coordinates from being fitted. This was a leftover check from whenMultivariatePolynomialFunctiononly allow 6 or less independent coordinates.Testing I've completed
Tested locally using data from the OpenCap paper, which uses a model with paths that depend on more than 6 coordinates.
Looking for feedback on...
CHANGELOG.md (choose one)
This change is