Ignore warnings related to deprecated stdext::checked_array_iterator on MSVC#3895
Ignore warnings related to deprecated stdext::checked_array_iterator on MSVC#3895adamkewley merged 2 commits intomainfrom
stdext::checked_array_iterator on MSVC#3895Conversation
|
It's going to be rough to actually rollout the latest spdlog, because it requires going through every printable type (incl. those from simbody) and annotating the relevant datastructures to say " OpenSim Creator's been getting this warning for a couple of years now, because it's compiling with Not exactly a great solution but if you want CI back up-and-running then I'd maybe consider first disabling those warnings and then separately try to sort out the spdlog upgrade, so that you aren't getting pressure from PRs etc. to fix CI |
|
Thanks @adamkewley, I think patching the issue by disabling warnings is better for now. I'll switch this PR to do that instead. |
spdlog to v1.14.1stdext::checked_array_iterator on MSVC
|
Seems to do the trick! - sucks to ignore warnings but it gets the project's wheels turning while evaluating what to do (imo, I'd de-integrate spdlog+fmt around the time OpenSim upgrades to C++20 on target platforms that include |
Fixes issue with the Windows 2022 GitHub Actions runner failing because MSVC deprecated
stdext::checked_array_iterator, which was used by an older version offmtlib(dependency of spdlog).Brief summary of changes
Updated spdlog to v1.14.1.Update: rather than try to update
spdlog, I've changed this PR to ignore the warning on MSVC (per @adamkewley's suggestion).Testing I've completed
Running the CI suite.
Looking for feedback on...
Should the added
target_compile_optionsbe moved outside of the macro (i.e., used only for libraries compiled withspdlog)?CHANGELOG.md (choose one)
This change is