Communicate through swig that PathPointSet::insert takes ownership #3276
Merged
Communicate through swig that PathPointSet::insert takes ownership #3276
Conversation
… the passed in pointer
Beef up the comment explaining the change
carmichaelong
approved these changes
Aug 11, 2022
Member
carmichaelong
left a comment
There was a problem hiding this comment.
LGTM. I also tested this artifact with the test code in MATLAB that was crashing and could not cause the same crash (after removing the additional markAdopted() lines in the MATLAB code)
Member
|
Oh @aymanhab actually one thing: maybe add something to the changelog? |
Update changelog
Member
Author
|
Thanks @carmichaelong 👍 Updated changelog, and will merge since no need to rebuild. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #3274
Brief summary of changes
Bindings for Python and Java now mark the passed in object to PathPointSet::insert as owned by the Set so it doesn't get double deleted or garbage collected early from scripting environment
Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
This change is