Skip to content

[mac_ai] testing: remove the kompute flavor#790

Merged
kpouget merged 1 commit intoopenshift-psap:mainfrom
kpouget:periodic
Jul 4, 2025
Merged

[mac_ai] testing: remove the kompute flavor#790
kpouget merged 1 commit intoopenshift-psap:mainfrom
kpouget:periodic

Conversation

@kpouget
Copy link
Contributor

@kpouget kpouget commented Jul 4, 2025 •
edited by coderabbitai bot
Loading

see ggml-org/llama.cpp#14501

Summary by CodeRabbit

  • Chores
    • Removed support for the "kompute" build flavor in configuration and build processes.
    • Updated test configuration to no longer skip platforms related to "kompute".
    • Simplified source preparation steps by eliminating modifications related to "kompute".

@openshift-ci
Copy link

openshift-ci bot commented Jul 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ashishkamra for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Jul 4, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The changes collectively remove support for the "kompute" build flavor from the llama_cpp container build and testing configuration. All related build steps, configuration entries, and source preparation commands specific to "kompute" have been deleted, effectively disabling this flavor across the build and test pipeline.

Changes

File(s) Change Summary
projects/mac_ai/testing/config.yaml Removed "kompute" from llama_cpp build flavors, platform checks, and test platform skips.
projects/mac_ai/testing/images/llama_cpp.containerfile Deleted step updating ggml-kompute submodule during container build.
projects/mac_ai/testing/prepare_llama_cpp.py Removed command disabling -Werror in Kompute CMakeLists.txt during source preparation.

Poem

A hop and a skip, Kompute’s gone away,
No more submodules in our build ballet.
The flavors are lighter, the configs are neat,
Llama trots forward with nimble feet.
Goodbye, Kompute, you’ve had your day—
The code hops on in a simpler way!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e42ca2b and 448afec.

📒 Files selected for processing (3)
  • projects/mac_ai/testing/config.yaml (2 hunks)
  • projects/mac_ai/testing/images/llama_cpp.containerfile (1 hunks)
  • projects/mac_ai/testing/prepare_llama_cpp.py (0 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kpouget kpouget enabled auto-merge July 4, 2025 12:43
@kpouget kpouget merged commit 21dd124 into openshift-psap:main Jul 4, 2025
6 of 8 checks passed
@kpouget kpouget deleted the periodic branch July 4, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kpouget