fix: auto-detect hub type when catalog type is empty by zakisk · Pull Request #2353 · tektoncd/pipelines-as-code

zakisk · 2025-12-11T06:34:44Z

📝 Description of the Change

When the catalog type is not specified, the code now probes the Artifact Hub stats endpoint to determine the catalog type. If the endpoint responds successfully, the catalog is treated as Artifact Hub; otherwise, it falls back to Tekton Hub.

Call /api/v1/stats endpoint to detect Artifact Hub catalogs
Fallback to Tekton Hub if the API call fails
Update tests with HTTP mock client for catalog type detection

👨🏻‍ Linked Jira

https://issues.redhat.com/browse/SRVKP-9248

🔗 Linked GitHub Issue

Fixes #

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

I have not used any AI assistance for this PR.
I have used AI assistance for this PR.

If you have used AI assistance, please provide the following details:

Which LLM was used?

Extent of AI Assistance:

Documentation and research only
Unit tests or E2E tests only
Code generation (parts of the code)
Full code generation (most of the PR)
PR description and comments
Commit message(s)

Important

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com

**💡You can use the script ./hack/add-llm-coauthor.sh to automatically add
these co-author trailers to your commits.

✅ Submitter Checklist

gemini-code-assist · 2025-12-11T06:34:58Z

Summary of Changes

Hello @zakisk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant improvement to how catalog types are determined. By implementing an intelligent auto-detection mechanism, the system can now dynamically identify whether an unspecified catalog is an Artifact Hub or a Tekton Hub, thereby enhancing the robustness and flexibility of catalog integration without requiring explicit configuration.

Highlights

Automatic Catalog Type Detection: The system now automatically detects the catalog type when it is not explicitly specified. It attempts to identify Artifact Hub catalogs by probing their /api/v1/stats endpoint.
Fallback Mechanism: If the probe to the Artifact Hub stats endpoint fails, the catalog type gracefully falls back to Tekton Hub, ensuring a default behavior.
Enhanced Test Coverage: New unit tests have been added and existing ones updated to incorporate an HTTP mock client, thoroughly validating the new catalog type detection and fallback logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

pipelines-as-code · 2025-12-11T06:35:25Z

🔍 PR Lint Feedback

Note: This automated check helps ensure your PR follows our contribution guidelines.

⚠️ Items that need attention:

🤖 AI attribution

The following commits lack an explicit AI attribution footer:

2c7398c fix: auto-detect hub type when catalog type is empty

If no AI assistance was used for a commit, you can ignore this warning.
Otherwise add an Assisted-by: or Co-authored-by: footer referencing the AI used.

ℹ️ Next Steps

Review and address the items above
Push new commits to update this PR
This comment will be automatically updated when issues are resolved

🔧 Admin Tools (click to expand)

Automated Issue/Ticket Creation:

/issue-create - Generate a GitHub issue from this PR content using AI
/jira-create - Create a SRVKP Jira ticket from this PR content using AI

⚠️ Important: Always review and edit generated content before finalizing tickets/issues.
The AI-generated content should be used as a starting point and may need adjustments.

These commands are available to maintainers and will post the generated content as PR comments for review.

_{🤖 This feedback was generated automatically by the PR CI system}

gemini-code-assist

Code Review

This pull request introduces a helpful feature to auto-detect the hub type when it's not explicitly configured. The implementation correctly probes the Artifact Hub and falls back to Tekton Hub, and the new logic is well-covered by tests. I have a couple of suggestions to improve the code by fixing a typo and adding logging for better debuggability.

pkg/hub/hub.go

pratap0007 · 2025-12-11T07:37:42Z

@zakisk We are using PAC SyncConfig function in the Operator here I think we should set the hub-catalog-type here, WDYT? cc: @vdemeester

zakisk · 2025-12-11T08:56:55Z

@zakisk We are using PAC SyncConfig function in the Operator here I think we should set the hub-catalog-type here, WDYT? cc: @vdemeester

yeah, but IMO I am not trying to set hub-catalog-type rather I am just proceeding with the appropriate hub type for current iteration because I think its user who should set the type otherwise we will decide type via API and don't touch the config. (but still I am open to hear from you @pratap0007 @vdemeester)

pratap0007 · 2025-12-11T09:34:47Z

@zakisk We are using PAC SyncConfig function in the Operator here I think we should set the hub-catalog-type here, WDYT? cc: @vdemeester

yeah, but IMO I am not trying to set hub-catalog-type rather I am just proceeding with the appropriate hub type for current iteration because I think its user who should set the type otherwise we will decide type via API and don't touch the config. (but still I am open to hear from you @pratap0007 @vdemeester)

yes, I see you are just deciding the hub-catalog-type but my point is, is this a good place to do it as this line might set hub-catalog-type to artifacthub in case of empty hub-catalog-type?

zakisk · 2025-12-11T09:41:07Z

@pratap0007 Yes, but in that case if user has not provided url PaC must proceed with ArtifactHub as default hub. we're doing this fix because user has configured custom hub and we're figuring out the HUB type.

pratap0007 · 2025-12-11T09:44:27Z

@pratap0007 Yes, but in that case if user has not provided url PaC must proceed with ArtifactHub as default hub. we're doing this fix because user has configured custom hub and we're figuring out the HUB type.

@zakisk sorry, I mentioned wrong code please check this one https://github.com/openshift-pipelines/pipelines-as-code/blob/main/pkg/params/settings/default.go#L21

pkg/params/settings/default.go

When the catalog type is not specified, the code now probes the Artifact Hub stats endpoint to determine the catalog type. If the endpoint responds successfully, the catalog is treated as Artifact Hub; otherwise, it falls back to Tekton Hub. - Call /api/v1/stats endpoint to detect Artifact Hub catalogs - Fallback to Tekton Hub if the API call fails - Update tests with HTTP mock client for catalog type detection https://issues.redhat.com/browse/SRVKP-9248 Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>

pratap0007 · 2025-12-12T12:14:38Z

LGTM

vdemeester

/lgtm

chmouel · 2025-12-16T07:45:26Z

this is to handle upgrade from OSP right? if the user don't have hub-type set then it will always end up trying to detect on every request (and due adding one http call more everytime to hub).....

@zakisk i think we can update the configmap instead to the right hub-type so we don't do another call again and again on every payload.

@pratap0007 better way would be to have the operator doing this, i think you added some logic to do some work on osp upgrade, can you try to reuse this code we have here to detect the hub type and set it properly in the configmap from the operator?

zakisk · 2025-12-16T11:54:15Z

i think we can update the configmap instead to the right hub-type so we don't do another call again and again on every payload.

yeah, makes sense!

pipelines-as-code bot added enhancement New feature or request fix testing labels Dec 11, 2025

gemini-code-assist bot reviewed Dec 11, 2025

View reviewed changes

pkg/hub/hub.go Outdated Show resolved Hide resolved

pkg/hub/hub.go Outdated Show resolved Hide resolved

zakisk force-pushed the SRVKP-9248-fix-catalog-type-on-empty-catalog-type branch from 5f52f32 to 32ac3f5 Compare December 11, 2025 06:56

zakisk requested a review from vdemeester December 11, 2025 07:02

zakisk mentioned this pull request Dec 11, 2025

fix: Set tektonhub as the default catalog type for custom Hub URLs #2351

Closed

41 tasks

zakisk force-pushed the SRVKP-9248-fix-catalog-type-on-empty-catalog-type branch from 32ac3f5 to 0e7b423 Compare December 11, 2025 10:11

vdemeester approved these changes Dec 11, 2025

View reviewed changes

pratap0007 reviewed Dec 11, 2025

View reviewed changes

pkg/params/settings/default.go Outdated Show resolved Hide resolved

zakisk force-pushed the SRVKP-9248-fix-catalog-type-on-empty-catalog-type branch from 0e7b423 to 0ef343c Compare December 11, 2025 12:04

pratap0007 mentioned this pull request Dec 12, 2025

Remove default Artifacthub url override tektoncd/operator#3091

Merged

4 tasks

zakisk force-pushed the SRVKP-9248-fix-catalog-type-on-empty-catalog-type branch from 0ef343c to 2c7398c Compare December 12, 2025 09:41

zakisk requested a review from vdemeester December 12, 2025 11:48

vdemeester approved these changes Dec 12, 2025

View reviewed changes

zakisk merged commit 063c543 into tektoncd:main Dec 15, 2025
8 of 15 checks passed

zakisk deleted the SRVKP-9248-fix-catalog-type-on-empty-catalog-type branch December 15, 2025 04:38

This was referenced Dec 18, 2025

[cherry-pick: release-v0.78.x] Remove default Artifacthub url override tektoncd/operator#3112

Closed

[cherry-pick: release-v0.78.x] Remove default Artifacthub url override tektoncd/operator#3120

Closed

pratap0007 mentioned this pull request Jan 27, 2026

fix: set the correct custom hub catalog type #2371

Merged

41 tasks

Conversation

zakisk commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description of the Change

👨🏻‍ Linked Jira

🔗 Linked GitHub Issue

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

✅ Submitter Checklist

Uh oh!

gemini-code-assist bot commented Dec 11, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

pipelines-as-code bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 PR Lint Feedback

⚠️ Items that need attention:

🤖 AI attribution

ℹ️ Next Steps

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

pratap0007 commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zakisk commented Dec 11, 2025

Uh oh!

pratap0007 commented Dec 11, 2025

Uh oh!

zakisk commented Dec 11, 2025

Uh oh!

pratap0007 commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pratap0007 commented Dec 12, 2025

Uh oh!

vdemeester left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chmouel commented Dec 16, 2025

Uh oh!

zakisk commented Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zakisk commented Dec 11, 2025 •

edited

Loading

pipelines-as-code bot commented Dec 11, 2025 •

edited

Loading

pratap0007 commented Dec 11, 2025 •

edited

Loading

pratap0007 commented Dec 11, 2025 •

edited

Loading